[Yaml] add inline parser context initializer #24060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26074f9 to
5c140e3
Compare
fabpot
reviewed
Sep 2, 2017
| @@ -223,9 +223,8 @@ private function doParse($value, $flags) | ||
| $context = 'mapping'; | ||
|
|
||
| // force correct settings |
There was a problem hiding this comment.
comment is not relevant anymore I suppose
5c140e3 to
1be23c2
Compare
Calling the parser to initialize some internal context does not look like a good idea. Additionally, this change allows to not accept null values in `Inline::parse()` in 3.4 anymore.
chalasr
approved these changes
Sep 6, 2017
fabpot
approved these changes
Sep 6, 2017
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Sep 6, 2017
This PR was merged into the 3.4 branch. Discussion ---------- [Yaml] add inline parser context initializer | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23262 (comment) | License | MIT | Doc PR | Calling the parser to initialize some internal context does not look like a good idea. Additionally, this change allows to not accept null values in `Inline::parse()` in 3.4 anymore. Commits ------- 1be23c2 [Yaml] add inline parser context initializer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling the parser to initialize some internal context does not look
like a good idea. Additionally, this change allows to not accept null
values in
Inline::parse()in 3.4 anymore.