[VarDumper] Prepare period caster for 4.0 #24034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maidmaid
commented
Aug 30, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #23668 |
| License | MIT |
| Doc PR | / |
chalasr
approved these changes
Aug 30, 2017
maidmaid
commented
Aug 30, 2017
| if (defined('HHVM_VERSION_ID') || \PHP_VERSION_ID < 50620 || (\PHP_VERSION_ID >= 70000 && \PHP_VERSION_ID < 70005)) { // see https://bugs.php.net/bug.php?id=71635 | ||
| return $a; | ||
| } | ||
|
|
||
| $dates = array(); | ||
| if (\PHP_VERSION_ID >= 70107) { // see https://bugs.php.net/bug.php?id=74639 |
There was a problem hiding this comment.
Minimal current PHP version is 7.1.3. What about bump it to 7.1.7 to avoid this condition?
There was a problem hiding this comment.
a caster is not enough a reason to bump the minimum version
|
Thank you @maidmaid. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 31, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- [VarDumper] Prepare period caster for 4.0 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23668 | License | MIT | Doc PR | / Commits ------- fd7352e Prepare period caster for 4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.