[Routing] Add the possibility to define a prefix for all routes of a controller #24031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
commented
Aug 29, 2017
| @@ -240,7 +241,7 @@ public function testInvokableClassWithMethodRouteLoad() | ||
|
|
||
| $this->assertNull($route, '->load ignores class route'); | ||
|
|
||
| $route = $routeCollection->get($methodRouteData['name']); | ||
| $route = $routeCollection->get($classRouteData['name'].$methodRouteData['name']); |
There was a problem hiding this comment.
Technically, that's a BC break, but I don't think this matters much as someone defining a class with an __invoke method would probably not define a name on the class @Route annotation (I don't see the point).
There was a problem hiding this comment.
I think you're right, because it would have to map to the __invoke method, even if @Route() was used for the service definition.
nicolas-grekas
approved these changes
Aug 31, 2017
chalasr
approved these changes
Aug 31, 2017
fabpot
added a commit
that referenced
this pull request
Sep 1, 2017
…ll routes of a controller (fabpot) This PR was merged into the 3.4 branch. Discussion ---------- [Routing] Add the possibility to define a prefix for all routes of a controller | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | sensiolabs/SensioFrameworkExtraBundle#283 | License | MIT | Doc PR | not yet This PR adds the possibility to define a name on a `@Route` annotation set on a controller class. The name is then used as a prefix for all routes defined in the controller. Commits ------- 00d959c [Routing] added the possibility to define a prefix for all routes of a controller
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to define a name on a
@Routeannotation set on a controller class. The name is then used as a prefix for all routes defined in the controller.