Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Security] add impersonator_user to "User was reloaded" log message #24026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[Security] add impersonator_user to "User was reloaded" log message #24026

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0707d13
add log message containing user and impersonator_user
gharlan Aug 29, 2017
2c90db8
reduced log messages
gharlan Aug 30, 2017
7de58d4
avoid empty impersonator_username
gharlan Aug 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions 20 src/Symfony/Component/Security/Http/Firewall/ContextListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
use Symfony\Component\Security\Core\Exception\UsernameNotFoundException;
use Symfony\Component\Security\Core\Exception\UnsupportedUserException;
use Symfony\Component\Security\Core\Role\SwitchUserRole;
use Symfony\Component\Security\Core\User\UserInterface;
use Symfony\Component\Security\Core\User\UserProviderInterface;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;
Expand Down Expand Up @@ -91,7 +92,10 @@ public function handle(GetResponseEvent $event)
$token = unserialize($token);

if (null !== $this->logger) {
$this->logger->debug('Read existing security token from the session.', array('key' => $this->sessionKey));
$this->logger->debug('Read existing security token from the session.', array(
'key' => $this->sessionKey,
'token_class' => is_object($token) ? get_class($token) : null,
));
}

if ($token instanceof TokenInterface) {
Expand Down Expand Up @@ -169,7 +173,19 @@ protected function refreshUser(TokenInterface $token)
$token->setUser($refreshedUser);

if (null !== $this->logger) {
$this->logger->debug('User was reloaded from a user provider.', array('username' => $refreshedUser->getUsername(), 'provider' => get_class($provider)));
$impersonatorUsername = null;
foreach ($token->getRoles() as $role) {
if ($role instanceof SwitchUserRole) {
$impersonatorUsername = $role->getSource()->getUsername();
break;
}
}

$this->logger->debug('User was reloaded from a user provider.', array(
'provider' => get_class($provider),
'username' => $refreshedUser->getUsername(),
'impersonator_username' => $impersonatorUsername,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see this info only on switching user, so maybe impersonator_username could be ignored if is it null?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, let's not add it if no switch_user in place.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldnt it be impersonated_username?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ro0NL not sure https://symfony.com/doc/current/security/impersonating_user.html

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right :) i mixed up.

In some cases you may need to get the object that represents the impersonating user rather than the impersonated user.

impersonating_username then?

cc @gharlan

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

symfony/symfony-docs#8320

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right :) 👍

));
}

return $token;
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.