[PhpUnitBridge] install PHPUnit 6 on PHP 7.2 #23952
Conversation
xabbuh
commented
Aug 22, 2017
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #23943 |
| License | MIT |
| Doc PR |
|
As phpunit 6 itself is not really backwards compatible due to the namespace changes: does the phpunit bridge add any backwards compat layer for it? Or will my tests just fail if my testsuite is running on phpunit 5 currently (with php 7.2) without using any namespaced phpunit base classes? |
| $PHPUNIT_VERSION = getenv('SYMFONY_PHPUNIT_VERSION') ?: '5.7'; | ||
| } else { | ||
| // PHPUnit 5.1 requires PHP 5.6+ | ||
| $PHPUNIT_VERSION = getenv('SYMFONY_PHPUNIT_VERSION') ?: '4.8'; |
There was a problem hiding this comment.
This changes the existing behavior. For PHP < 5.6, the env variable was ignored before, forcing to use 4.8, as this is the only usable version there:
- newer versions are not supported on these PHP runtimes
- older versions than 4.8 are not supported by the bridge.
I would keep this behavior (anyway, changing it is a BC break).
There was a problem hiding this comment.
You are right. I misread the nested ternary operators.
|
@dmaicher if you run your testsuite on PHPUnit 6 while using However, making your testsuite compatible with several PHPUnit versions is possible. PHPUnit 4.8.35 and 5.4.3+ are providing the |
|
Maybe it will help for #23671. 👍 but there will be some work to do. |
|
I think this should be merged in 3.3 instead. |
|
👍 for 3.3 |
|
rebased on 3.3 |
|
Thank you @xabbuh. |
This PR was merged into the 3.3 branch. Discussion ---------- [PhpUnitBridge] install PHPUnit 6 on PHP 7.2 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23943 | License | MIT | Doc PR | Commits ------- 30336ea install PHPUnit 6 on PHP 7.2
| @@ -1,6 +1,11 @@ | ||
| CHANGELOG | ||
| ========= | ||
|
|
||
| 3.4.0 |
There was a problem hiding this comment.
removed after the merge (2230e31)