[FrameworkBundle] Allow micro kernel to subscribe events easily #23812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Aug 6, 2017
dunglas
approved these changes
Aug 7, 2017
fabpot
approved these changes
Aug 9, 2017
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Aug 9, 2017
…ts easily (ogizanagi) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] Allow micro kernel to subscribe events easily | Q | A | ------------- | --- | Branch? | 3.4 <!-- see comment below --> | Bug fix? | no | New feature? | yes <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #16982 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A just by implementing `EventSubscriberInterface`. See related issue for other implementation suggestions. Commits ------- b31542e [FrameworkBundle] Allow micro kernel to subscribe events easily
|
added a note in the CHANGELOG in 6727d41 |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 20, 2017
…ssInterface (nicolas-grekas) This PR was squashed before being merged into the 3.4 branch (closes #24257). Discussion ---------- [HttpKernel][DI] Enable Kernel to implement CompilerPassInterface | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - In the same spirit as #13761 that allowed DI exts to be also compiler passes, and as #23812 that allowed the kernel to listen to events, in our new bundle-less world, should we allow the kernel to register itself as a compiler pass? That would make some scenario possible (like having a `TestKernel` that turns some services public.) Commits ------- 6973a1a [HttpKernel][DI] Enable Kernel to implement CompilerPassInterface
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just by implementing
EventSubscriberInterface. See related issue for other implementation suggestions.