Ignore memcached missing key error on session destroy #23752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13b6657 to
d69ff13
Compare
| return $this->memcached->delete($this->prefix.$sessionId); | ||
| $result = $this->memcached->delete($this->prefix.$sessionId); | ||
|
|
||
| if (!$result && $this->memcached->getResultCode() == \Memcached::RES_NOTFOUND) { |
There was a problem hiding this comment.
return $result || $this->memcached->getResultCode() == \Memcached::RES_NOTFOUND;
d69ff13 to
29538b6
Compare
fabpot
approved these changes
Aug 9, 2017
|
Thank you @jderusse. |
fabpot
added a commit
that referenced
this pull request
Aug 9, 2017
…russe) This PR was merged into the 2.7 branch. Discussion ---------- Ignore memcached missing key error on session destroy | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18574 | License | MIT | Doc PR | NA Since PHP 7 session_regenerate_id triggers a warning when the session is not started. This PR, changes the behaviours of session_destroy in the `MemcachedSessionHandler` by returning true when the user try to delete a non-existing session. Other handler: - LegacyPdoSessionHandler => don't check if key exists - MongoDbSessionHandler => don't check if key exists - NullSessionHandler => always true - PdoSessionHandler => don't check if key exists Commits ------- 29538b6 Ignore memcached missing key error on dession destroy
This was referenced Aug 28, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PHP 7 session_regenerate_id triggers a warning when the session is not started.
This PR, changes the behaviours of session_destroy in the
MemcachedSessionHandlerby returning true when the user try to delete a non-existing session.Other handler: