Autoconfigure instances of ArgumentValueResolverInterface #23719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a new feature so it must target 3.4. |
|
Ah rats, I was in two minds about if this constituted a new feature or a bug. I leant towards bug for 3.3.x as I hoped this could be interpreted as "it should have been there at the start but it was missed". What do you reckon @weaverryan? |
|
@BPScott Even if it should have been part of 3.3, we missed that and Symfony is perfectly usable without it. So, that qualifies as a new feature. |
Add the controller.argument_value_resolver tag to instances of ArgumentValueResolverInterface
chalasr
approved these changes
Aug 2, 2017
weaverryan
approved these changes
Aug 2, 2017
xabbuh
approved these changes
Aug 2, 2017
|
Thank you @BPScott. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 3, 2017
…ace (BPScott) This PR was merged into the 3.4 branch. Discussion ---------- Autoconfigure instances of ArgumentValueResolverInterface | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23701 | License | MIT | Doc PR | n/a Autoconfigure instances of `Symfony\Component\HttpKernel\Controller\ArgumentValueResolverInterface` so they get the `controller.argument_value_resolver` tag automatically added to them. This avoids avoid having to tag each resolver or add an `_instanceof` configuration such as ```yaml _instanceof: Symfony\Component\HttpKernel\Controller\ArgumentValueResolverInterface: tags: [controller.argument_value_resolver] ``` Commits ------- ee4dc20 Autoconfigure instances of ArgumentValueResolverInterface
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autoconfigure instances of
Symfony\Component\HttpKernel\Controller\ArgumentValueResolverInterfaceso they get thecontroller.argument_value_resolvertag automatically added to them.This avoids avoid having to tag each resolver or add an
_instanceofconfiguration such as