[VarDumper] Make dump() variadic #23709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chalasr
commented
Jul 29, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
ro0NL
reviewed
Jul 29, 2017
| { | ||
| foreach (func_get_args() as $var) { | ||
| if (!$vars) { | ||
| throw new ArgumentCountError('dump() requires at least 1 argument.'); |
There was a problem hiding this comment.
\ArgumentCountError?
edit: guess it's not really needed in the root namespace :)
| @@ -15,9 +15,13 @@ | ||
| /** | ||
| * @author Nicolas Grekas <p@tchwork.com> | ||
| */ | ||
| function dump($var) | ||
| function dump(...$vars) |
There was a problem hiding this comment.
should be $var, ...$moreVars
Simperfit
approved these changes
Jul 29, 2017
nicolas-grekas
approved these changes
Jul 29, 2017
stof
approved these changes
Jul 29, 2017
ogizanagi
approved these changes
Jul 30, 2017
fabpot
approved these changes
Aug 1, 2017
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Aug 1, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- [VarDumper] Make dump() variadic | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- 33b737b Make dump() variadic
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.