[Form] Add notice to upgrade to PHP v7.0.8+ #23705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@symfony/mergers should be merged before releasing v3.3.6 |
ogizanagi
approved these changes
Jul 28, 2017
fabpot
approved these changes
Jul 28, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jul 28, 2017
This PR was merged into the 3.3 branch. Discussion ---------- [Form] Add notice to upgrade to PHP v7.0.8+ | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22973 | License | MIT | Doc PR | - So that PHP7 < 7.0.8 users get a notice about the issue. Commits ------- 0347e5a [Form] Add notice to upgrade to PHP v7.0.8+
ghost
reviewed
Jul 29, 2017
| @@ -85,6 +85,9 @@ public function __construct(FormDataExtractorInterface $dataExtractor) | ||
| */ | ||
| public function collect(Request $request, Response $response, \Exception $exception = null) | ||
| { | ||
| if (70000 <= \PHP_VERSION_ID && \PHP_VERSION_ID < 70800) { | ||
| @trigger_error('A bug in PHP v7.0.0 to v7.0.7 is breaking the Form panel, please upgrade to v7.0.8 or more.', E_USER_DEPRECATED); |
There was a problem hiding this comment.
Indeed, that's better. Done in a6f44d2. Thanks for the suggestion.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that PHP7 < 7.0.8 users get a notice about the issue.