From 7b6d8948cea71235eeb6c23ee33c8e1ceecbd6d1 Mon Sep 17 00:00:00 2001 From: Nicolas Grekas Date: Wed, 26 Jul 2017 18:05:14 +0200 Subject: [PATCH] [Console][WebServerBundle] Use "exec" when possible --- src/Symfony/Bundle/WebServerBundle/WebServer.php | 9 ++++----- src/Symfony/Bundle/WebServerBundle/composer.json | 4 ++-- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/src/Symfony/Bundle/WebServerBundle/WebServer.php b/src/Symfony/Bundle/WebServerBundle/WebServer.php index b65cec1cb768b..8edbe2bf56ec2 100644 --- a/src/Symfony/Bundle/WebServerBundle/WebServer.php +++ b/src/Symfony/Bundle/WebServerBundle/WebServer.php @@ -13,7 +13,6 @@ use Symfony\Component\Process\PhpExecutableFinder; use Symfony\Component\Process\Process; -use Symfony\Component\Process\ProcessBuilder; use Symfony\Component\Process\Exception\RuntimeException; /** @@ -151,11 +150,11 @@ private function createServerProcess(WebServerConfig $config) throw new \RuntimeException('Unable to find the PHP binary.'); } - $builder = new ProcessBuilder(array($binary, '-S', $config->getAddress(), $config->getRouter())); - $builder->setWorkingDirectory($config->getDocumentRoot()); - $builder->setTimeout(null); + $process = new Process(array($binary, '-S', $config->getAddress(), $config->getRouter())); + $process->setWorkingDirectory($config->getDocumentRoot()); + $process->setTimeout(null); - return $builder->getProcess(); + return $process; } private function getDefaultPidFile() diff --git a/src/Symfony/Bundle/WebServerBundle/composer.json b/src/Symfony/Bundle/WebServerBundle/composer.json index ce8a60d136eb0..829e110c35206 100644 --- a/src/Symfony/Bundle/WebServerBundle/composer.json +++ b/src/Symfony/Bundle/WebServerBundle/composer.json @@ -17,9 +17,9 @@ ], "require": { "php": ">=5.5.9", - "symfony/console": "~2.8.8|~3.0.8|~3.1.2|~3.2", + "symfony/console": "~3.3", "symfony/http-kernel": "~3.3", - "symfony/process": "~2.8|~3.0" + "symfony/process": "~3.3" }, "autoload": { "psr-4": { "Symfony\\Bundle\\WebServerBundle\\": "" },