[Console][WebServerBundle] Use "exec" when possible #23686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Jul 26, 2017
| Q | A |
|---|---|
| Branch? | 3.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #23568 |
| License | MIT |
| Doc PR | - |
439d15c to
7b6d894
Compare
nicolas-grekas
commented
Jul 26, 2017
| @@ -17,9 +17,9 @@ | ||
| ], | ||
| "require": { | ||
| "php": ">=5.5.9", | ||
| "symfony/console": "~2.8.8|~3.0.8|~3.1.2|~3.2", | ||
| "symfony/console": "~3.3", |
There was a problem hiding this comment.
there is no need to keep pre-3.3 deps for 3.3-introduced bundles IMHO, that makes things easier
|
Confirming this PR does indeed fix the inability to properly kill the web server process via the |
chalasr
approved these changes
Jul 26, 2017
| $builder->setTimeout(null); | ||
| $process = new Process(array($binary, '-S', $config->getAddress(), $config->getRouter())); | ||
| $process->setWorkingDirectory($config->getDocumentRoot()); | ||
| $process->setTimeout(null); |
There was a problem hiding this comment.
return new Process(array($binary, '-S', $config->getAddress(), $config->getRouter()), $config->getDocumentRoot(), null, null); btw?
There was a problem hiding this comment.
More readable as is to me.
ogizanagi
approved these changes
Jul 26, 2017
xabbuh
approved these changes
Jul 27, 2017
fabpot
approved these changes
Jul 27, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jul 27, 2017
…as-grekas) This PR was merged into the 3.3 branch. Discussion ---------- [Console][WebServerBundle] Use "exec" when possible | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23568 | License | MIT | Doc PR | - Commits ------- 7b6d894 [Console][WebServerBundle] Use "exec" when possible
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.