Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Webprofiler] Added blocks that allows extension of the profiler page. #23680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[Webprofiler] Added blocks that allows extension of the profiler page. #23680

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c6245a
Added blocks that allows extension of the profiler page.
Nyholm Jul 26, 2017
d146727
Updated block names
Nyholm Jul 28, 2017
2abbcb2
Removed before/after
Nyholm Aug 22, 2017
85db592
Renamed to "messages"
Nyholm Aug 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed before/after
  • Loading branch information
@Nyholm
Nyholm committed Aug 22, 2017
commit 2abbcb2431e9dbd715a6f378d952377d6b02700e
4 changes: 2 additions & 2 deletions 4 src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/translation.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@

<h2>Translation Messages</h2>

{% block before_translation_messages %}{% endblock %}
{% block translation_messages %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we are in a template managing templates, what about just messages? Would that be clear enough?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Inside we have blocks named "missing_messages", "fallback_messages", and "defined_messages". So naming "translation_messages" to "messages" makes sense.


{# sort translation messages in groups #}
{% set messages_defined, messages_missing, messages_fallback = [], [], [] %}
Expand Down Expand Up @@ -161,7 +161,7 @@
</div>
</div>

{% block after_translation_messages %}{% endblock %}
{% endblock %}

{% endblock %}

Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.