LoggerDataCollector: caching data for performance in dev mode

symfony · vtsykun · Jul 21, 2017 · Jul 21, 2017 · e60e42fb94cc7a7cc92a9c9c348c02588511b4f6
commit e60e42fb94cc7a7cc92a9c9c348c02588511b4f6
diff --git a/src/Symfony/Component/HttpKernel/DataCollector/LoggerDataCollector.php b/src/Symfony/Component/HttpKernel/DataCollector/LoggerDataCollector.php
@@ -25,6 +25,7 @@ class LoggerDataCollector extends DataCollector implements LateDataCollectorInte
 {
    private $logger;
    private $containerPathPrefix;
+    private static $serializeData;

    public function __construct($logger = null, $containerPathPrefix = null)
    {
@@ -43,12 +44,24 @@ public function collect(Request $request, Response $response, \Exception $except
        // everything is done as late as possible
    }

+    /**
+     * {@inheritdoc}
+     */
+    public function serialize()
+    {
+        if (null === self::$serializeData) {
+            self::$serializeData = serialize($this->data);
+        }
+
+        return self::$serializeData;
+    }
+
    /**
     * {@inheritdoc}
     */
    public function lateCollect()
    {
-        if (null !== $this->logger) {
+        if (null !== $this->logger && null === self::$serializeData) {
            $containerDeprecationLogs = $this->getContainerDeprecationLogs();
            $this->data = $this->computeErrorsCount($containerDeprecationLogs);
            $this->data['compiler_logs'] = $this->getContainerCompilerLogs();