[WebProfilerBundle][TwigBundle] Fix infinite js loop on exception pages #23577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Jul 18, 2017
fabpot
reviewed
Jul 19, 2017
| @@ -516,8 +516,8 @@ | ||
|
|
||
| /* Prevents from disallowing clicks on links inside toggles */ | ||
| var toggleLinks = document.querySelectorAll('.sf-toggle a'); | ||
| for (var i = 0; i < toggleLinks.length; i++) { | ||
| addEventListener(toggleLinks[i], 'click', function(e) { | ||
| for (var j = 0; j < toggleLinks.length; j++) { |
There was a problem hiding this comment.
This change is not needed, right? Here i is not defined. I supposed you did that for consistency with the other file?
There was a problem hiding this comment.
Good catch actually: There is no reason there is any difference between the two files. The right fix is that it shouldn't have been called within the above loop at the first place.
fabpot
approved these changes
Jul 19, 2017
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Jul 19, 2017
…ception pages (ogizanagi) This PR was merged into the 3.3 branch. Discussion ---------- [WebProfilerBundle][TwigBundle] Fix infinite js loop on exception pages | Q | A | ------------- | --- | Branch? | 3.3 <!-- see comment below --> | Bug fix? | yes | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #23566 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Commits ------- 295fda9 [WebProfilerBundle][TwigBundle] Fix infinite js loop on exception pages
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.