Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Serializer] Fix workaround min php version #23217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2017
Merged

[Serializer] Fix workaround min php version #23217

merged 1 commit into from
Jun 18, 2017

Conversation

ogizanagi
Copy link
Contributor

@ogizanagi ogizanagi commented Jun 17, 2017 •
edited
Loading

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #22444 (comment)
License MIT
Doc PR N/A

@ogizanagi ogizanagi mentioned this pull request Jun 17, 2017
Merged
GuilhemN
GuilhemN approved these changes Jun 17, 2017
View reviewed changes
Copy link
Contributor

@GuilhemN GuilhemN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@xabbuh xabbuh added this to the 3.4 milestone Jun 18, 2017
@fabpot
Copy link
Member

fabpot commented Jun 18, 2017

Thank you @ogizanagi.

@fabpot fabpot merged commit 74db2e6 into symfony:3.4 Jun 18, 2017
fabpot added a commit that referenced this pull request Jun 18, 2017
@fabpot
minor #23217 [Serializer] Fix workaround min php version (ogizanagi)
b223241 
This PR was merged into the 3.4 branch.

Discussion
----------

[Serializer] Fix workaround min php version

| Q             | A
| ------------- | ---
| Branch?       | 3.4 <!-- see comment below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | #22444 (comment) <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Commits
-------

74db2e6 [Serializer] Fix workaround min php version
@ogizanagi ogizanagi deleted the fix/datetime_normalizer_php_5 branch June 18, 2017 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

@GuilhemN GuilhemN GuilhemN approved these changes

Assignees
No one assigned
Labels
Bug Serializer Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
5 participants
@ogizanagi @fabpot @xabbuh @GuilhemN @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.