[HttpFoundation] add back support for legacy constant values #23074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure we should go that far in BC, especially since this is non serializable data (since we're talking about consts used in static props only.) |
|
The thing is we even advised to use these strings in the previous docblocks of |
apetitpa
suggested changes
Jun 6, 2017
| @@ -672,7 +672,17 @@ public static function setTrustedHeaderName($key, $value) | ||
| { | ||
| @trigger_error(sprintf('The "%s()" method is deprecated since version 3.3 and will be removed in 4.0. Use the $trustedHeaderSet argument of the Request::setTrustedProxies() method instead.', __METHOD__), E_USER_DEPRECATED); | ||
|
|
||
| if (!array_key_exists($key, self::$trustedHeaders)) { | ||
| if ('forwared' === $key) { |
fabpot
requested changes
Jun 9, 2017
| @@ -672,7 +672,17 @@ public static function setTrustedHeaderName($key, $value) | ||
| { | ||
| @trigger_error(sprintf('The "%s()" method is deprecated since version 3.3 and will be removed in 4.0. Use the $trustedHeaderSet argument of the Request::setTrustedProxies() method instead.', __METHOD__), E_USER_DEPRECATED); | ||
|
|
||
| if (!array_key_exists($key, self::$trustedHeaders)) { | ||
| if ('forwared' === $key) { |
fabpot
approved these changes
Jun 14, 2017
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jun 14, 2017
…es (xabbuh) This PR was merged into the 3.3 branch. Discussion ---------- [HttpFoundation] add back support for legacy constant values | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Due to the data type change of the `Request::HEADER_` constants in Symfony 3.3 #23067 introduced a small BC break if someone used the old constant values statically instead of referring to the constants themselves. Commits ------- fddd754 add back support for legacy constant values
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the data type change of the
Request::HEADER_constants in Symfony 3.3 #23067 introduced a small BC break if someone used the old constant values statically instead of referring to the constants themselves.