[PhpUnitBridge] Adjust PHPUnit class_alias check to also check for namespaced class #22925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @GawainLynch. |
fabpot
added a commit
that referenced
this pull request
May 27, 2017
…heck for namespaced class (GawainLynch) This PR was merged into the 3.3 branch. Discussion ---------- [PhpUnitBridge] Adjust PHPUnit class_alias check to also check for namespaced class | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Some projects, e.g. [Codeception](https://github.com/Codeception/Codeception/blob/2.3.2/shim.php#L47), also alias pre-PHPUnit namespaces leading to a collision and exceptions such as: ``` [PHPUnit\Framework\Exception (2)] Cannot declare class Symfony\Bridge\PhpUnit\SymfonyTestsListener, because the name is already in use ``` This just add a check for the namespaced class, and exits if either aliased or exists. Commits ------- 7ba3afd Adjust PHPUnit class_alias check to also check for namespaced class
nicolas-grekas
added a commit
to nicolas-grekas/symfony
that referenced
this pull request
May 28, 2017
|
This breaks the bridge, see #22929 for reversal. |
nicolas-grekas
added a commit
that referenced
this pull request
May 28, 2017
…ias check (nicolas-grekas) This PR was merged into the 4.0-dev branch. Discussion ---------- Revert "bug #22925 [PhpUnitBridge] Adjust PHPUnit class_alias check This reverts commit cfb090d, reversing changes made to 4e8f403. | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - PR #22925 made the bridge fail with: > Fatal error: Declaration of Symfony\Bridge\PhpUnit\SymfonyTestsListener::addSkippedTest() must be compatible with that of PHPUnit_Framework_TestListener::addSkippedTest() in /home/travis/build/symfony/symfony/vendor/symfony/phpunit-bridge/SymfonyTestsListener.php on line 32 See https://travis-ci.org/symfony/symfony/builds/236863221 on 3.3 and https://travis-ci.org/symfony/symfony/builds/236863238 on 3.4 Commits ------- 934c0c0 Revert "bug #22925 [PhpUnitBridge] Adjust PHPUnit class_alias check to also check for namespaced class (GawainLynch)"
nicolas-grekas
added a commit
that referenced
this pull request
May 28, 2017
…ias check (nicolas-grekas) This PR was merged into the 3.3 branch. Discussion ---------- Revert "bug #22925 [PhpUnitBridge] Adjust PHPUnit class_alias check This reverts commit cfb090d, reversing changes made to 4e8f403. | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - PR #22925 made the bridge fail with: > Fatal error: Declaration of Symfony\Bridge\PhpUnit\SymfonyTestsListener::addSkippedTest() must be compatible with that of PHPUnit_Framework_TestListener::addSkippedTest() in /home/travis/build/symfony/symfony/vendor/symfony/phpunit-bridge/SymfonyTestsListener.php on line 32 See https://travis-ci.org/symfony/symfony/builds/236863221 on 3.3 and https://travis-ci.org/symfony/symfony/builds/236863238 on 3.4 Commits ------- 934c0c0 Revert "bug #22925 [PhpUnitBridge] Adjust PHPUnit class_alias check to also check for namespaced class (GawainLynch)"
nicolas-grekas
added a commit
that referenced
this pull request
May 28, 2017
* 3.3: Revert "bug #22925 [PhpUnitBridge] Adjust PHPUnit class_alias check to also check for namespaced class (GawainLynch)"
|
@GawainLynch please open an other PR if you want to give it another try. |
|
@nicolas-grekas I will, do. Bolt uses Codeception for acceptance tests, and we've locked at 3.2.1 (before they added that alias), but that makes things "interesting" in the future 😉 I'll think though approach for a bit, and then try try try again 😄 |
|
A solution might be to check the PHPUnit version instead of relying on class existence to detect PHPUnit versions |
|
@stof but, if I'm right, for Symfony we always do the opposite of what you are proposing: instead of relying on version numbers (for Symfony kernel, Symfony Forms, etc.) we always check if some class exists or if some method exists, etc. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some projects, e.g. Codeception, also alias pre-PHPUnit namespaces leading to a collision and exceptions such as:
This just add a check for the namespaced class, and exits if either aliased or exists.