Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

use getProjectDir() when possible #22843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2017
Merged

use getProjectDir() when possible #22843

merged 1 commit into from
May 23, 2017

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented May 22, 2017

Q A
Branch? 3.3
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets continues #22315
License MIT
Doc PR

@xabbuh
Copy link
Member Author

xabbuh commented May 22, 2017

There are some other places where we use getRootDir()/%kernel.root_dir%, but updating them may not be safe.

@xabbuh xabbuh added this to the 3.3 milestone May 22, 2017
@fabpot
Copy link
Member

fabpot commented May 23, 2017

Thank you @xabbuh.

@fabpot fabpot merged commit a8e298a into symfony:3.3 May 23, 2017
fabpot added a commit that referenced this pull request May 23, 2017
@fabpot
minor #22843 use getProjectDir() when possible (xabbuh)
222325f 
This PR was merged into the 3.3 branch.

Discussion
----------

use getProjectDir() when possible

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | continues #22315
| License       | MIT
| Doc PR        |

Commits
-------

a8e298a use getProjectDir() when possible
@xabbuh xabbuh deleted the pr-22315 branch May 23, 2017 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
FrameworkBundle Status: Reviewed WebServerBundle
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @fabpot @javiereguiluz @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.