[Debug] Deprecate support for stacked errors #22832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * @group legacy | ||
| * @expectedDeprecation Support for stacking errors is deprecated since Symfony 3.4 and will be removed in 4.0. | ||
| * @expectedDeprecation Support for unstacking errors is deprecated since Symfony 3.4 and will be removed in 4.0. |
There was a problem hiding this comment.
test are failing, partly because this isn't triggered anymore since the stacking calls are removed from DebugClassLoader
I think the entire test case should be remove
dunno about the other failure yet
|
rebase needed |
linaori
reviewed
May 22, 2017
UPGRADE-3.4.md
Outdated
| Debug | ||
| ----- | ||
|
|
||
| * support for stacked errors in the `ErrorHanlder` is deprecated and will |
UPGRADE-4.0.md
Outdated
| @@ -70,6 +70,8 @@ Debug | ||
| * `FlattenException::getTrace()` now returns additional type descriptions | ||
| `integer` and `float`. | ||
|
|
||
| * support for stacked errors in the `ErrorHanlder` has been removed |
|
FWIW I spent a little bit yesterday trying to figure out a way to get this failing test to work (mbabker@fde02c6 and mbabker@0e87986 being failed solutions, actually they caused PHP 5.6 to start erroring on my Travis builds). The only other option I can come up with right now is to just drop it, I don't know what's triggering a parse error but it clearly isn't happening with the stacking gone. |
|
Thank you @mbabker. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 6, 2017
This PR was merged into the 3.4 branch. Discussion ---------- [Debug] Deprecate support for stacked errors | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #22804 | License | MIT | Doc PR | n/a Per discussion in #22804 this deprecates support for error stacking. // @nicolas-grekas Commits ------- 04b8b80 Deprecate support for stacked errors
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in #22804 this deprecates support for error stacking. // @nicolas-grekas