[Yaml] remove deprecated features #22770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
May 19, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
e6c9a2d to
6f4ad01
Compare
38d9b3d to
020178b
Compare
This was referenced May 21, 2017
020178b to
5d584de
Compare
GuilhemN
reviewed
May 24, 2017
| if (!(Yaml::PARSE_KEYS_AS_STRINGS & $flags)) { | ||
| $evaluatedKey = self::evaluateScalar($key, $flags, $references); | ||
|
|
||
| if ('' !== $key && $evaluatedKey !== $key && !is_string($evaluatedKey)) { | ||
| @trigger_error('Implicit casting of incompatible mapping keys to strings is deprecated since version 3.3 and will throw \Symfony\Component\Yaml\Exception\ParseException in 4.0. Pass the PARSE_KEYS_AS_STRING flag to explicitly enable the type casts.', E_USER_DEPRECATED); | ||
| throw new ParseException('Non-string mapping keys are not supported. Pass the Yaml::PARSE_KEYS_AS_STRINGS flag to cast them to strings.', self::$parsedLineNumber + 1, $mapping); | ||
| } | ||
| } | ||
|
|
||
| if (':' !== $key && (!isset($mapping[$i + 1]) || !in_array($mapping[$i + 1], array(' ', ',', '[', ']', '{', '}'), true))) { |
There was a problem hiding this comment.
':' !== $key should be removed, right?
| @@ -481,24 +427,20 @@ private static function parseMapping($mapping, $flags, &$i = 0, $references = ar | ||
| // key | ||
| $key = self::parseScalar($mapping, $flags, array(':', ' '), $i, false, array(), true); |
There was a problem hiding this comment.
The last argument should be removed, isn't it? (and the according logic in parseScalar)
5d584de to
efe2337
Compare
GuilhemN
approved these changes
May 24, 2017
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
May 24, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- [Yaml] remove deprecated features | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- efe2337 [Yaml] remove deprecated features
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.