[DependencyInjection] remove deprecated code in YamlFileLoader class #22750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59c7813 to
493e290
Compare
dunglas
approved these changes
May 18, 2017
xabbuh
reviewed
May 18, 2017
| @@ -795,8 +795,6 @@ private function checkDefinition($id, array $definition, $file) | ||
| if ($throw) { | ||
| throw new InvalidArgumentException(sprintf('The configuration key "%s" is unsupported for definition "%s" in "%s". Allowed configuration keys are "%s".', $key, $id, $file, implode('", "', $keywords))); | ||
| } | ||
|
|
||
| @trigger_error(sprintf('The configuration key "%s" is unsupported for service definition "%s" in "%s". Allowed configuration keys are "%s". The YamlFileLoader object will raise an exception instead in Symfony 4.0 when detecting an unsupported service configuration key.', $key, $id, $file, implode('", "', $keywords)), E_USER_DEPRECATED); |
There was a problem hiding this comment.
The deprecation message mentions an exception that will be risen in 4.0. That's not yet happening with this change, is it?
There was a problem hiding this comment.
Nope not yet! The PR is WIP.
There was a problem hiding this comment.
@hhamon I suggest you to work on each deprecation one by one by repalcing them with proper exception instead of first removing all deprecations. It will lower the risk of forgetting to add an exception
There was a problem hiding this comment.
@stof okay thanks for the advise ;)
|
rebase needed to see tests green |
493e290 to
e4c7fda
Compare
|
WIP or not WIP? (personally I'd prefer not using WIP in the title of PRs, that's only noise :P ) |
|
@nicolas-grekas it's WIP. I can close it and reopen when it's ready if you prefer. |
3943661 to
5a71da0
Compare
|
@nicolas-grekas no more WIP :) |
xabbuh
approved these changes
May 19, 2017
f020901 to
854efce
Compare
|
Thank you @hhamon. |
fabpot
added a commit
that referenced
this pull request
May 21, 2017
…leLoader class (hhamon) This PR was merged into the 4.0-dev branch. Discussion ---------- [DependencyInjection] remove deprecated code in YamlFileLoader class | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | yes | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Commits ------- 854efce [DependencyInjection] remove deprecated YAML configuration features and syntax
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.