Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Bump minimum version to PHP 7.1 for Symfony 4 #22733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 18, 2017
Merged

Bump minimum version to PHP 7.1 for Symfony 4 #22733

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c850733
bumped minimum version to PHP 7.1
fabpot May 17, 2017
6633c8b
Allow individual bridges, bundles and components to be used with 4.0
dunglas May 18, 2017
4758c2c
Tweak travis and appveyor for Symfony 4
nicolas-grekas May 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
bumped minimum version to PHP 7.1
  • Loading branch information
@fabpot @nicolas-grekas
fabpot authored and nicolas-grekas committed May 18, 2017
commit c85073370342aa6416b57177d980f6ab879cf894
11 changes: 5 additions & 6 deletions 11 .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,18 @@ addons:

env:
global:
- MIN_PHP=5.5.9
- SYMFONY_PROCESS_PHP_TEST_BINARY=~/.phpenv/versions/5.6/bin/php
- MIN_PHP=7.1.0
- SYMFONY_PROCESS_PHP_TEST_BINARY=~/.phpenv/versions/7.1/bin/php

matrix:
include:
# Use the newer stack for HHVM as HHVM does not support Precise anymore since a long time and so Precise has an outdated version
- php: hhvm-3.18
- php: hhvm-stable
sudo: required
dist: trusty
group: edge
- php: 5.5
- php: 5.6
- php: 7.0
- php: 7.1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should have a test running the fullstack testsuite on latest 7.1 too IMO

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have one, like in the previous branches: the deps=low line does it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deps=low is a per-component build, not a fullstack build. It does not test the requirements of the fullstack

Copy link
Member

@nicolas-grekas nicolas-grekas May 18, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I misunderstood what you meant, the line you're​ asking for doesn't exist on the SF3 lines. Thus we should not add it since it has never been required.

- php: 7.1
env: deps=high
- php: 7.1
env: deps=low
Expand Down
4 changes: 0 additions & 4 deletions 4 appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ init:
install:
- mkdir c:\php && cd c:\php
- appveyor DownloadFile https://raw.githubusercontent.com/symfony/binary-utils/master/cacert.pem
- appveyor DownloadFile https://github.com/symfony/binary-utils/releases/download/v0.1/php-5.5.9-nts-Win32-VC11-x86.zip
- 7z x php-5.5.9-nts-Win32-VC11-x86.zip -y >nul
- appveyor DownloadFile https://github.com/symfony/binary-utils/releases/download/v0.1/php-7.1.3-Win32-VC14-x64.zip
- cd ext
- appveyor DownloadFile https://github.com/symfony/binary-utils/releases/download/v0.1/php_apcu-4.0.10-5.5-nts-vc11-x86.zip
Expand Down Expand Up @@ -59,8 +57,6 @@ test_script:
- cd c:\php && 7z x php-7.1.3-Win32-VC14-x64.zip -y >nul && copy /Y php.ini-min php.ini
- cd c:\projects\symfony
- php phpunit src\Symfony --exclude-group benchmark,intl-data || SET X=!errorlevel!
- cd c:\php && 7z x php-5.5.9-nts-Win32-VC11-x86.zip -y >nul && copy /Y php.ini-min php.ini
- cd c:\projects\symfony
- SET SYMFONY_PHPUNIT_SKIPPED_TESTS=phpunit.skipped
- php phpunit src\Symfony --exclude-group benchmark,intl-data || SET X=!errorlevel!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line should be removed, as it was the one running tests on 5.5.9. there is no need to run tests a second time on 7.1.3 without changing the php.ini (skipped tests will stay the same)

- copy /Y c:\php\php.ini-max c:\php\php.ini
Expand Down
2 changes: 1 addition & 1 deletion 2 composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
}
],
"require": {
"php": ">=5.5.9",
"php": "^7.1.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we keep the ">=" operator?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this constraint forbids using the existing version with PHP 8. I think it is fine. I'm almost sure that the current code will not work with PHP 8 (PHP major versions will break BC for sure if we look at the existing releases where even minor versions have a hard time preserving BC fully). This way, when PHP 8 starts to come out, we can update our requirements once we start testing it with PHP 7

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way exclude PHP8, IMO it's a good thing and avoid future PR to exclude it and then re-enable PHP8 after BC breaks corrected.

"doctrine/common": "~2.4",
"fig/link-util": "^1.0",
"twig/twig": "~1.32|~2.2",
Expand Down
24 changes: 12 additions & 12 deletions 24 src/Symfony/Bridge/Doctrine/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,22 +16,22 @@
}
],
"require": {
"php": ">=5.5.9",
"php": "^7.1.3",
"doctrine/common": "~2.4",
"symfony/polyfill-mbstring": "~1.0"
},
"require-dev": {
"symfony/stopwatch": "~2.8|~3.0|~4.0.0",
"symfony/dependency-injection": "~3.3|~4.0.0",
"symfony/form": "^3.2.5|~4.0.0",
"symfony/http-kernel": "~2.8|~3.0|~4.0.0",
"symfony/property-access": "~2.8|~3.0|~4.0.0",
"symfony/property-info": "~2.8|3.0|~4.0.0",
"symfony/proxy-manager-bridge": "~2.8|~3.0|~4.0.0",
"symfony/security": "~2.8|~3.0|~4.0.0",
"symfony/expression-language": "~2.8|~3.0|~4.0.0",
"symfony/validator": "^2.8.18|^3.2.5|~4.0.0",
"symfony/translation": "~2.8|~3.0|~4.0.0",
"symfony/stopwatch": "~2.8|~3.0|~4.0",
"symfony/dependency-injection": "~3.3|~4.0",
"symfony/form": "^3.2.5|~4.0",
"symfony/http-kernel": "~2.8|~3.0|~4.0",
"symfony/property-access": "~2.8|~3.0|~4.0",
"symfony/property-info": "~2.8|3.0|~4.0",
"symfony/proxy-manager-bridge": "~2.8|~3.0|~4.0",
"symfony/security": "~2.8|~3.0|~4.0",
"symfony/expression-language": "~2.8|~3.0|~4.0",
"symfony/validator": "^2.8.18|^3.2.5|~4.0",
"symfony/translation": "~2.8|~3.0|~4.0",
"doctrine/data-fixtures": "1.0.*",
"doctrine/dbal": "~2.4",
"doctrine/orm": "^2.4.5"
Expand Down
10 changes: 5 additions & 5 deletions 10 src/Symfony/Bridge/Monolog/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@
}
],
"require": {
"php": ">=5.5.9",
"php": "^7.1.3",
"monolog/monolog": "~1.19",
"symfony/http-kernel": "~2.8|~3.0|~4.0.0"
"symfony/http-kernel": "~2.8|~3.0|~4.0"
},
"require-dev": {
"symfony/console": "~2.8|~3.0|~4.0.0",
"symfony/event-dispatcher": "~2.8|~3.0|~4.0.0",
"symfony/var-dumper": "~3.3|~4.0.0"
"symfony/console": "~2.8|~3.0|~4.0",
"symfony/event-dispatcher": "~2.8|~3.0|~4.0",
"symfony/var-dumper": "~3.3|~4.0"
},
"conflict": {
"symfony/http-foundation": "<3.3"
Expand Down
6 changes: 3 additions & 3 deletions 6 src/Symfony/Bridge/ProxyManager/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@
}
],
"require": {
"php": ">=5.5.9",
"symfony/dependency-injection": "~2.8|~3.0|~4.0.0",
"php": "^7.1.3",
"symfony/dependency-injection": "~2.8|~3.0|~4.0",
"ocramius/proxy-manager": "~0.4|~1.0|~2.0"
},
"require-dev": {
"symfony/config": "~2.8|~3.0|~4.0.0"
"symfony/config": "~2.8|~3.0|~4.0"
},
"autoload": {
"psr-4": { "Symfony\\Bridge\\ProxyManager\\": "" },
Expand Down
32 changes: 16 additions & 16 deletions 32 src/Symfony/Bridge/Twig/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,27 +16,27 @@
}
],
"require": {
"php": ">=5.5.9",
"php": "^7.1.3",
"twig/twig": "~1.28|~2.0"
},
"require-dev": {
"fig/link-util": "^1.0",
"symfony/asset": "~2.8|~3.0|~4.0.0",
"symfony/finder": "~2.8|~3.0|~4.0.0",
"symfony/form": "^3.2.7|~4.0.0",
"symfony/http-kernel": "~3.2|~4.0.0",
"symfony/asset": "~2.8|~3.0|~4.0",
"symfony/finder": "~2.8|~3.0|~4.0",
"symfony/form": "^3.2.7|~4.0",
"symfony/http-kernel": "~3.2|~4.0",
"symfony/polyfill-intl-icu": "~1.0",
"symfony/routing": "~2.8|~3.0|~4.0.0",
"symfony/templating": "~2.8|~3.0|~4.0.0",
"symfony/translation": "~2.8|~3.0|~4.0.0",
"symfony/yaml": "~2.8|~3.0|~4.0.0",
"symfony/security": "~2.8|~3.0|~4.0.0",
"symfony/security-acl": "~2.8|~3.0",
"symfony/stopwatch": "~2.8|~3.0|~4.0.0",
"symfony/console": "~2.8|~3.0|~4.0.0",
"symfony/var-dumper": "~2.8.10|~3.1.4|~3.2|~4.0.0",
"symfony/expression-language": "~2.8|~3.0|~4.0.0",
"symfony/web-link": "~3.3|~4.0.0"
"symfony/routing": "~2.8|~3.0|~4.0",
"symfony/templating": "~2.8|~3.0|~4.0",
"symfony/translation": "~2.8|~3.0|~4.0",
"symfony/yaml": "~2.8|~3.0|~4.0",
"symfony/security": "~2.8|~3.0|~4.0",
"symfony/security-acl": "~2.8|~3.0|~4.0",
"symfony/stopwatch": "~2.8|~3.0|~4.0",
"symfony/console": "~2.8|~3.0|~4.0",
"symfony/var-dumper": "~2.8.10|~3.1.4|~3.2|~4.0",
"symfony/expression-language": "~2.8|~3.0|~4.0",
"symfony/web-link": "~3.3|~4.0"
},
"suggest": {
"symfony/finder": "",
Expand Down
14 changes: 7 additions & 7 deletions 14 src/Symfony/Bundle/DebugBundle/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,15 @@
}
],
"require": {
"php": ">=5.5.9",
"symfony/http-kernel": "~2.8|~3.0|~4.0.0",
"symfony/twig-bridge": "~2.8|~3.0|~4.0.0",
"symfony/var-dumper": "~2.8|~3.0|~4.0.0"
"php": "^7.1.3",
"symfony/http-kernel": "~2.8|~3.0|~4.0",
"symfony/twig-bridge": "~2.8|~3.0|~4.0",
"symfony/var-dumper": "~2.8|~3.0|~4.0"
},
"require-dev": {
"symfony/config": "~3.3|~4.0.0",
"symfony/dependency-injection": "~3.3|~4.0.0",
"symfony/web-profiler-bundle": "~2.8|~3.0|~4.0.0"
"symfony/config": "~3.3|~4.0",
"symfony/dependency-injection": "~3.3|~4.0",
"symfony/web-profiler-bundle": "~2.8|~3.0|~4.0"
},
"suggest": {
"symfony/config": "For service container configuration",
Expand Down
62 changes: 31 additions & 31 deletions 62 src/Symfony/Bundle/FrameworkBundle/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,44 +16,44 @@
}
],
"require": {
"php": ">=5.5.9",
"php": "^7.1.3",
"ext-xml": "*",
"symfony/cache": "~3.3|~4.0.0",
"symfony/class-loader": "~3.2",
"symfony/dependency-injection": "~3.3-beta2|~4.0.0",
"symfony/config": "~3.3|~4.0.0",
"symfony/event-dispatcher": "~3.3|~4.0.0",
"symfony/http-foundation": "~3.3|~4.0.0",
"symfony/http-kernel": "~3.3|~4.0.0",
"symfony/cache": "~3.3|~4.0",
"symfony/class-loader": "~3.2|~4.0",
"symfony/dependency-injection": "~3.3-beta2|~4.0",
"symfony/config": "~3.3|~4.0",
"symfony/event-dispatcher": "~3.3|~4.0",
"symfony/http-foundation": "~3.3|~4.0",
"symfony/http-kernel": "~3.3|~4.0",
"symfony/polyfill-mbstring": "~1.0",
"symfony/filesystem": "~2.8|~3.0|~4.0.0",
"symfony/finder": "~2.8|~3.0|~4.0.0",
"symfony/routing": "~3.3|~4.0.0",
"symfony/stopwatch": "~2.8|~3.0|~4.0.0",
"symfony/filesystem": "~2.8|~3.0|~4.0",
"symfony/finder": "~2.8|~3.0|~4.0",
"symfony/routing": "~3.3|~4.0",
"symfony/stopwatch": "~2.8|~3.0|~4.0",
"doctrine/cache": "~1.0"
},
"require-dev": {
"fig/link-util": "^1.0",
"symfony/asset": "~3.3|~4.0.0",
"symfony/browser-kit": "~2.8|~3.0|~4.0.0",
"symfony/console": "~3.3|~4.0.0",
"symfony/css-selector": "~2.8|~3.0|~4.0.0",
"symfony/dom-crawler": "~2.8|~3.0|~4.0.0",
"symfony/asset": "~3.3|~4.0",
"symfony/browser-kit": "~2.8|~3.0|~4.0",
"symfony/console": "~3.3|~4.0",
"symfony/css-selector": "~2.8|~3.0|~4.0",
"symfony/dom-crawler": "~2.8|~3.0|~4.0",
"symfony/polyfill-intl-icu": "~1.0",
"symfony/security": "~2.8|~3.0|~4.0.0",
"symfony/form": "~3.3|~4.0.0",
"symfony/expression-language": "~2.8|~3.0|~4.0.0",
"symfony/process": "~2.8|~3.0|~4.0.0",
"symfony/security-core": "~3.2|~4.0.0",
"symfony/security-csrf": "~2.8|~3.0|~4.0.0",
"symfony/serializer": "~3.3|~4.0.0",
"symfony/translation": "~3.2|~4.0.0",
"symfony/templating": "~2.8|~3.0|~4.0.0",
"symfony/validator": "~3.3|~4.0.0",
"symfony/workflow": "~3.3|~4.0.0",
"symfony/yaml": "~3.2|~4.0.0",
"symfony/property-info": "~3.3|~4.0.0",
"symfony/web-link": "~3.3|~4.0.0",
"symfony/security": "~2.8|~3.0|~4.0",
"symfony/form": "~3.3|~4.0",
"symfony/expression-language": "~2.8|~3.0|~4.0",
"symfony/process": "~2.8|~3.0|~4.0",
"symfony/security-core": "~3.2|~4.0",
"symfony/security-csrf": "~2.8|~3.0|~4.0",
"symfony/serializer": "~3.3|~4.0",
"symfony/translation": "~3.2|~4.0",
"symfony/templating": "~2.8|~3.0|~4.0",
"symfony/validator": "~3.3|~4.0",
"symfony/workflow": "~3.3|~4.0",
"symfony/yaml": "~3.2|~4.0",
"symfony/property-info": "~3.3|~4.0",
"symfony/web-link": "~3.3|~4.0",
"doctrine/annotations": "~1.0",
"phpdocumentor/reflection-docblock": "^3.0",
"twig/twig": "~1.26|~2.0",
Expand Down
43 changes: 21 additions & 22 deletions 43 src/Symfony/Bundle/SecurityBundle/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,30 +16,29 @@
}
],
"require": {
"php": ">=5.5.9",
"symfony/security": "~3.3|~4.0.0",
"symfony/dependency-injection": "~3.3-beta2|~4.0.0",
"symfony/http-kernel": "~3.3|~4.0.0",
"symfony/polyfill-php70": "~1.0"
"php": "^7.1.3",
"symfony/security": "~3.3|~4.0",
"symfony/dependency-injection": "~3.3-beta2|~4.0",
"symfony/http-kernel": "~3.3|~4.0"
},
"require-dev": {
"symfony/asset": "~2.8|~3.0|~4.0.0",
"symfony/browser-kit": "~2.8|~3.0|~4.0.0",
"symfony/console": "~3.2|~4.0.0",
"symfony/css-selector": "~2.8|~3.0|~4.0.0",
"symfony/dom-crawler": "~2.8|~3.0|~4.0.0",
"symfony/form": "^2.8.18|^3.2.5|~4.0.0",
"symfony/framework-bundle": "^3.2.8|~4.0.0",
"symfony/http-foundation": "~2.8|~3.0|~4.0.0",
"symfony/security-acl": "~2.8|~3.0",
"symfony/translation": "~2.8|~3.0|~4.0.0",
"symfony/twig-bundle": "~2.8|~3.0|~4.0.0",
"symfony/twig-bridge": "~2.8|~3.0|~4.0.0",
"symfony/process": "~2.8|~3.0|~4.0.0",
"symfony/validator": "^3.2.5|~4.0.0",
"symfony/var-dumper": "~3.3|~4.0.0",
"symfony/yaml": "~2.8|~3.0|~4.0.0",
"symfony/expression-language": "~2.8|~3.0|~4.0.0",
"symfony/asset": "~2.8|~3.0|~4.0",
"symfony/browser-kit": "~2.8|~3.0|~4.0",
"symfony/console": "~3.2|~4.0",
"symfony/css-selector": "~2.8|~3.0|~4.0",
"symfony/dom-crawler": "~2.8|~3.0|~4.0",
"symfony/form": "^2.8.18|^3.2.5|~4.0",
"symfony/framework-bundle": "^3.2.8|~4.0",
"symfony/http-foundation": "~2.8|~3.0|~4.0",
"symfony/security-acl": "~2.8|~3.0|~4.0",
"symfony/translation": "~2.8|~3.0|~4.0",
"symfony/twig-bundle": "~2.8|~3.0|~4.0",
"symfony/twig-bridge": "~2.8|~3.0|~4.0",
"symfony/process": "~2.8|~3.0|~4.0",
"symfony/validator": "^3.2.5|~4.0",
"symfony/var-dumper": "~3.3|~4.0",
"symfony/yaml": "~2.8|~3.0|~4.0",
"symfony/expression-language": "~2.8|~3.0|~4.0",
"doctrine/doctrine-bundle": "~1.4",
"twig/twig": "~1.28|~2.0"
},
Expand Down
24 changes: 12 additions & 12 deletions 24 src/Symfony/Bundle/TwigBundle/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,25 +16,25 @@
}
],
"require": {
"php": ">=5.5.9",
"php": "^7.1.3",
"symfony/config": "~3.2",
"symfony/twig-bridge": "^3.3",
"symfony/http-foundation": "~2.8|~3.0",
"symfony/http-kernel": "^3.3",
"twig/twig": "^1.32|^2.2"
},
"require-dev": {
"symfony/asset": "~2.8|~3.0|~4.0.0",
"symfony/stopwatch": "~2.8|~3.0|~4.0.0",
"symfony/dependency-injection": "~3.3|~4.0.0",
"symfony/expression-language": "~2.8|~3.0|~4.0.0",
"symfony/finder": "~2.8|~3.0|~4.0.0",
"symfony/form": "~2.8|~3.0|~4.0.0",
"symfony/routing": "~2.8|~3.0|~4.0.0",
"symfony/templating": "~2.8|~3.0|~4.0.0",
"symfony/yaml": "~2.8|~3.0|~4.0.0",
"symfony/framework-bundle": "^3.2.8|~4.0.0",
"symfony/web-link": "~3.3|~4.0.0",
"symfony/asset": "~2.8|~3.0|~4.0",
"symfony/stopwatch": "~2.8|~3.0|~4.0",
"symfony/dependency-injection": "~3.3|~4.0",
"symfony/expression-language": "~2.8|~3.0|~4.0",
"symfony/finder": "~2.8|~3.0|~4.0",
"symfony/form": "~2.8|~3.0|~4.0",
"symfony/routing": "~2.8|~3.0|~4.0",
"symfony/templating": "~2.8|~3.0|~4.0",
"symfony/yaml": "~2.8|~3.0|~4.0",
"symfony/framework-bundle": "^3.2.8|~4.0",
"symfony/web-link": "~3.3|~4.0",
"doctrine/annotations": "~1.0"
},
"conflict": {
Expand Down
21 changes: 10 additions & 11 deletions 21 src/Symfony/Bundle/WebProfilerBundle/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,19 +16,18 @@
}
],
"require": {
"php": ">=5.5.9",
"symfony/http-kernel": "~3.2|~4.0.0",
"symfony/polyfill-php70": "~1.0",
"symfony/routing": "~2.8|~3.0|~4.0.0",
"symfony/twig-bridge": "~2.8|~3.0|~4.0.0",
"twig/twig": "~1.28|~2.0",
"symfony/var-dumper": "~3.3|~4.0.0"
"php": "^7.1.3",
"symfony/http-kernel": "~3.2|~4.0",
"symfony/routing": "~2.8|~3.0|~4.0",
"symfony/twig-bridge": "~2.8|~3.0|~4.0",
"symfony/var-dumper": "~3.3|~4.0",
"twig/twig": "~1.28|~2.0"
},
"require-dev": {
"symfony/config": "~2.8|~3.0|~4.0.0",
"symfony/console": "~2.8|~3.0|~4.0.0",
"symfony/dependency-injection": "~3.3|~4.0.0",
"symfony/stopwatch": "~2.8|~3.0|~4.0.0"
"symfony/config": "~2.8|~3.0|~4.0",
"symfony/console": "~2.8|~3.0|~4.0",
"symfony/dependency-injection": "~3.3|~4.0",
"symfony/stopwatch": "~2.8|~3.0|~4.0"
},
"conflict": {
"symfony/dependency-injection": "<3.3",
Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.