[FrameworkBundle] Adding the extension XML #22676
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR name should be prepended with [FrameworkBundle], for the rest I'm 👍 |
|
Oh right, I redid this pull request on FrameworkBundle symfony/framework-bundle#15 |
|
Don't make PR on symfony/framework-bundle#15, this is a read-only split of the full-stack repo. This #22676 PR is good, you just have to rename the PR and add [FrameworkBundle] at the beginning of it so it can be tagged properly and fabbot.io doesn't complain 🙂 |
required by XmlUtils and not installed by default
|
Thank you @flug. |
fabpot
added a commit
that referenced
this pull request
May 9, 2017
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #22676). Discussion ---------- [FrameworkBundle] Adding the extension XML | Q | A | ------------- | --- | Branch? | <3.3 | Bug fix? | yes | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->  This pull request is referenced on  <!-- - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. - Please fill in this template according to the PR you're about to submit. - Replace this comment by a description of what your PR is solving. --> Commits ------- 6fe2ad0 [FrameworkBundle] Adding the extension XML
|
I am not sure about this change. We did not explicitly require other PHP standard extensions in the past, did we? And if we were to do this for the FrameworkBundle, we should IMO do the same for the other bundles too. |
Merged
This was referenced May 29, 2017
Merged
Merged
Merged
fabpot
added a commit
that referenced
this pull request
Jul 6, 2017
This PR was merged into the 2.7 branch. Discussion ---------- require the XML PHP extension | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22676 (comment), symfony/symfony-standard#1099 | License | MIT | Doc PR | I suggest to either revert #22676 or to be consistent and require the XML extension in all bundles as well as in the `symfony/symfony` package. Commits ------- 032e654 require the XML PHP extension
This was referenced Aug 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is referenced on