Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[EventDispatcher] fix: unwrap listeners for correct info #22541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2017

Conversation

dmaicher
Copy link
Contributor

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets related to #22520
License MIT
Doc PR -

Fixes problem where listeners were displayed as Symfony\Component\EventDispatcher\Debug\WrappedListener::__invoke() in the profiler. It now shows the correct callable.

@fabpot
Copy link
Member

fabpot commented Apr 26, 2017

Thank you @dmaicher.

@fabpot fabpot merged commit d8c5869 into symfony:2.8 Apr 26, 2017
fabpot added a commit that referenced this pull request Apr 26, 2017
…dmaicher)

This PR was merged into the 2.8 branch.

Discussion
----------

[EventDispatcher] fix: unwrap listeners for correct info

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | related to #22520
| License       | MIT
| Doc PR        | -

Fixes problem where listeners were displayed as `Symfony\Component\EventDispatcher\Debug\WrappedListener::__invoke() ` in the profiler. It now shows the correct callable.

Commits
-------

d8c5869 [EventDispatcher] fix: unwrap listeners for correct info
This was referenced May 1, 2017
dmaicher added a commit to dmaicher/symfony that referenced this pull request May 1, 2017
dmaicher added a commit to dmaicher/symfony that referenced this pull request May 1, 2017
dmaicher added a commit to dmaicher/symfony that referenced this pull request May 1, 2017
nicolas-grekas added a commit that referenced this pull request May 2, 2017
This PR was merged into the 3.2 branch.

Discussion
----------

[EventDispatcher] fix merge of #22541 from 2.8

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This cleans up a test case that was merged from 2.8 into 3.2 here: 824dc8b

@fabpot due to different implementations I created 2 PR's:

2.8: #22541
3.2: #22568

So the 2.8 merge into 3.2 of my change-set introduced some unused variable `$isWrapped` here: 824dc8b#diff-af3c4fbca8bb77957c00087543ae5a4dR113

This PR just cleans it up and also removes the data provider 😉

Commits
-------

f67eba8 [EventDispatcher] fix merge of #22541 from 2.8
nicolas-grekas added a commit that referenced this pull request May 4, 2017
* 3.2:
  [appveyor] Run the test suite on PHP 7.1
  [appveyor][3.x] Run the test suite on PHP 7.1
  [EventDispatcher] fix merge of #22541 from 2.8
  bumped Symfony version to 3.2.9
  updated VERSION for 3.2.8
  updated CHANGELOG for 3.2.8
  bumped Symfony version to 2.8.21
  updated VERSION for 2.8.20
  updated CHANGELOG for 2.8.20
  bumped Symfony version to 2.7.28
  updated VERSION for 2.7.27
  update CONTRIBUTORS for 2.7.27
  updated CHANGELOG for 2.7.27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.