Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Asset] Starting slash should indicate no basePath wanted #22528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[Asset] Starting slash should indicate no basePath wanted #22528

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
da85fee
No change - using "bar" intead of foo 2 times for clarity
weaverryan Apr 26, 2017
91664fe
Changing behavior back to earlier behavior: an opening / says you do …
weaverryan Apr 26, 2017
b399e98
Tweaks thanks to @stloyd
weaverryan Apr 27, 2017
8fde941
Using faster check for opening slash
weaverryan Apr 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tweaks thanks to @stloyd
  • Loading branch information
@weaverryan
weaverryan committed Apr 27, 2017
commit b399e98c7e66fdc44c3622dd9fe916526943d4a0
2 changes: 1 addition & 1 deletion 2 src/Symfony/Component/Asset/PathPackage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public function getUrl($path)

$versionedPath = $this->getVersionStrategy()->applyVersion($path);

if ($this->isAbsoluteUrl($versionedPath) || '/' === substr($versionedPath, 0, 1)) {
if ($this->isAbsoluteUrl($versionedPath) || 0 === strpos($versionedPath, '/')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using '/' === $versionedPath[0] is even faster (and already used above). We just need to handle the case of the empty string.
strpos still requires looking at the whole string for the common case of needing the base path

return $versionedPath;
}

Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.