[DI] Allow service subscribers to leverage autowiring to know where their locator should be injected #22457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Apr 17, 2017
| Q | A |
|---|---|
| Branch? | 3.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
513aef4 to
956a6de
Compare
dunglas
reviewed
Apr 19, 2017
| @@ -13,6 +13,7 @@ | ||
|
|
||
| use DummyProxyDumper; | ||
| use PHPUnit\Framework\TestCase; | ||
| use Psr\Container\ContainerInterface as PsrContainerInterface; |
There was a problem hiding this comment.
Why do you need to use an alias?
…he locator should be injected
956a6de to
e407b3d
Compare
|
👍 |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Apr 25, 2017
…now where their locator should be injected (nicolas-grekas) This PR was merged into the 3.3-dev branch. Discussion ---------- [DI] Allow service subscribers to leverage autowiring to know where their locator should be injected | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- e407b3d [DI] Allow service subscribers to leverage autowiring to know where the locator should be injected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.