[PropertyInfo] Prevent returning int values in some cases.

symfony · fabpot · Apr 13, 2017 · Apr 13, 2017 · Apr 13, 2017 · b190ec241e3a95a824487fee72617e01021e5cb6
commit b190ec241e3a95a824487fee72617e01021e5cb6
diff --git a/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php b/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php
@@ -64,7 +64,7 @@ public function getProperties($class, array $context = array())

        $properties = array();
        foreach ($reflectionClass->getProperties(\ReflectionProperty::IS_PUBLIC) as $reflectionProperty) {
-            $properties[$reflectionProperty->name] = true;
+            $properties[$reflectionProperty->name] = $reflectionProperty->name;
        }

        foreach ($reflectionClass->getMethods(\ReflectionMethod::IS_PUBLIC) as $reflectionMethod) {
@@ -79,10 +79,10 @@ public function getProperties($class, array $context = array())
            if (!$reflectionClass->hasProperty($propertyName) && !preg_match('/^[A-Z]{2,}/', $propertyName)) {
                $propertyName = lcfirst($propertyName);
            }
-            $properties[$propertyName] = true;
+            $properties[$propertyName] = $propertyName;
        }

-        return array_keys($properties);
+        return array_values($properties);
    }

    /**

diff --git a/src/Symfony/Component/PropertyInfo/Tests/Extractors/ReflectionExtractorTest.php b/src/Symfony/Component/PropertyInfo/Tests/Extractors/ReflectionExtractorTest.php
@@ -32,7 +32,7 @@ protected function setUp()

    public function testGetProperties()
    {
-        $this->assertEquals(
+        $this->assertSame(
            array(
                'bal',
                'parent',
@@ -49,6 +49,7 @@ public function testGetProperties()
                'a',
                'DOB',
                'Id',
+                '123',
                'c',
                'd',
                'e',

diff --git a/src/Symfony/Component/PropertyInfo/Tests/Fixtures/Dummy.php b/src/Symfony/Component/PropertyInfo/Tests/Fixtures/Dummy.php
@@ -116,4 +116,8 @@ public function getDOB()
    public function getId()
    {
    }
+
+    public function get123()
+    {
+    }
 }