[DI] Make tagged abstract services throw earlier #22420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Apr 13, 2017
Koc
reviewed
Apr 13, 2017
| * | ||
| * @return array An array of tags with the tagged service as key, holding a list of attribute arrays | ||
| */ | ||
| public function findTaggedServiceIds($name) | ||
| public function findTaggedServiceIds($name, $throwOnAbstract = false) |
There was a problem hiding this comment.
what about set null for now (and consider it as false), trigger deprecation warning if no argument value provided (null), change it to true by default for 4.0?
There was a problem hiding this comment.
this is mostly internal, so not sure it's worth it
but please open a PR if you want to work on it
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Apr 13, 2017
…las-grekas) This PR was squashed before being merged into the 3.3-dev branch (closes #22420). Discussion ---------- [DI] Make tagged abstract services throw earlier | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - As spotted by @stof in #22388 (comment), skipping abstract tagged services removes an opportunity to report config mistakes to users. Instead of skipping them, let's throw as done before (thus reverting #22039, ping @chalasr). I made `$container->findTaggedServiceIds()` accept a 2nd arg to make this more systematic. To keep the possibility to have abstract tagged services *for the purpose of tag inheritance*, `ResolveTagsInheritancePass` now resets their tags. Commits ------- 388e4b3 [DI] Make tagged abstract services throw earlier cd06c12 Revert "minor #22039 Skip abstract definitions in compiler passes (chalasr)"
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As spotted by @stof in #22388 (comment), skipping abstract tagged services removes an opportunity to report config mistakes to users.
Instead of skipping them, let's throw as done before (thus reverting #22039, ping @chalasr).
I made
$container->findTaggedServiceIds()accept a 2nd arg to make this more systematic.To keep the possibility to have abstract tagged services for the purpose of tag inheritance,
ResolveTagsInheritancePassnow resets their tags.