[DI] Populate class of ChildDefinition when its id matches an existing FQCN #22362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Apr 11, 2017
…ches an existing FQCN (nicolas-grekas) This PR was merged into the 3.3-dev branch. Discussion ---------- [DI] Populate class of ChildDefinition when its id matches an existing FQCN | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22345 | License | MIT | Doc PR | - See linked issue for expected DX. Instead of doing a "continue", let's throw to force the resolution of any ambiguities. There is a minor potential BC Break, if one uses an ambiguous FQCN as child-definition id in 3.2 or below. To me, this should be rare, and easy to fix (compile time only). The DX enhancement this PR provides looks worth it. > Service definition "App\Foo\Child" has a parent but no class, and its name looks like a FQCN. Either the class is missing or you want to inherit it from the parent service. To resolve this ambiguity, please rename this service to a non-FQCN (e.g. using dots), or create the missing class. Commits ------- 3200d37 [DI] Populate class of ChildDefinition when its id matches an existing FQCN
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See linked issue for expected DX.
Instead of doing a "continue", let's throw to force the resolution of any ambiguities.
There is a minor potential BC Break, if one uses an ambiguous FQCN as child-definition id in 3.2 or below.
To me, this should be rare, and easy to fix (compile time only).
The DX enhancement this PR provides looks worth it.