Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[HttpKernel] Resolve invokable controllers short notations using ServiceValueResolver #22330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2017

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Apr 7, 2017

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #22202
License MIT
Doc PR n/a

Register the service id as an alias of id:__invoke so that using the invokable short notation (id only) triggers the ServiceArgumentResolver.

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BPScott
Copy link
Contributor

BPScott commented Apr 7, 2017

Yay, thanks @chalasr!

@fabpot
Copy link
Member

fabpot commented Apr 7, 2017

Thank you @chalasr.

@fabpot fabpot merged commit 717fa85 into symfony:master Apr 7, 2017
fabpot added a commit that referenced this pull request Apr 7, 2017
… using ServiceValueResolver (chalasr)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[HttpKernel] Resolve invokable controllers short notations using ServiceValueResolver

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22202
| License       | MIT
| Doc PR        | n/a

Register the service id as an alias of `id:__invoke` so that using the invokable short notation (id only) triggers the ServiceArgumentResolver.

Commits
-------

717fa85 Resolve invokable controllers short notations using ServiceValueResolver
@chalasr chalasr deleted the service-arg-invokable branch April 7, 2017 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.