Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[DI] Fix the xml schema #22280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2017
Merged

[DI] Fix the xml schema #22280

merged 1 commit into from
Apr 5, 2017

Conversation

GuilhemN
Copy link
Contributor

@GuilhemN GuilhemN commented Apr 4, 2017

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@@ -140,8 +140,8 @@
</xsd:complexType>

<xsd:complexType name="property" mixed="true">
<xsd:choice minOccurs="0" maxOccurs="1">
Copy link
Contributor Author

@GuilhemN GuilhemN Apr 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one was the default value.

@@ -153,8 +153,8 @@
</xsd:complexType>

<xsd:complexType name="argument" mixed="true">
<xsd:choice maxOccurs="unbounded">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allowed having several anonymous services in the same argument while only the first was considered by the loader.

<xsd:complexType name="call" mixed="true">
<xsd:choice maxOccurs="unbounded">
<xsd:element name="argument" type="argument" minOccurs="0" maxOccurs="unbounded" />
<xsd:element name="service" type="service" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't used.

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Apr 4, 2017
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fabpot
Copy link
Member

fabpot commented Apr 5, 2017

Thank you @GuilhemN.

@fabpot fabpot merged commit f2ef1ee into symfony:2.7 Apr 5, 2017
fabpot added a commit that referenced this pull request Apr 5, 2017
This PR was merged into the 2.7 branch.

Discussion
----------

[DI] Fix the xml schema

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

f2ef1ee [DI] Fix the xml schema
@GuilhemN GuilhemN deleted the XMLSCHEMA branch April 5, 2017 15:22
This was referenced May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.