-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[DI] Fix the xml schema #22280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DI] Fix the xml schema #22280
Conversation
@@ -140,8 +140,8 @@ | ||
</xsd:complexType> | ||
|
||
<xsd:complexType name="property" mixed="true"> | ||
<xsd:choice minOccurs="0" maxOccurs="1"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one was the default value.
@@ -153,8 +153,8 @@ | ||
</xsd:complexType> | ||
|
||
<xsd:complexType name="argument" mixed="true"> | ||
<xsd:choice maxOccurs="unbounded"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This allowed having several anonymous services in the same argument while only the first was considered by the loader.
<xsd:complexType name="call" mixed="true"> | ||
<xsd:choice maxOccurs="unbounded"> | ||
<xsd:element name="argument" type="argument" minOccurs="0" maxOccurs="unbounded" /> | ||
<xsd:element name="service" type="service" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wasn't used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thank you @GuilhemN. |
This PR was merged into the 2.7 branch. Discussion ---------- [DI] Fix the xml schema | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- f2ef1ee [DI] Fix the xml schema
Uh oh!
There was an error while loading. Please reload this page.