[FrameworkBundle] Update console fixtures after #22217 #22278
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis is hanging? |
|
@ro0NL No, it's just that there is a lot of activity, and the queue is quite large right now :) |
|
Monitoring travis.. and PHP7 still fails. What a day... edit: wait.. that could actually be a deps issue.. ill have a look at composer file. |
|
Not sure what needs to be done here; |
|
@ro0NL Not sure but I'd say |
|
|
|
🎉 thx @chalasr for helping out and pointing out these issues. |
| @@ -38,7 +38,7 @@ | ||
| }, | ||
| "require-dev": { | ||
| "symfony/browser-kit": "~2.4|~3.0.0", | ||
| "symfony/console": "~2.8.8|~3.0.8", | ||
| "symfony/console": "~2.8.19|~3.3", |
|
Thank you @ro0NL. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 4, 2017
…ro0NL) This PR was squashed before being merged into the 2.8 branch (closes #22278). Discussion ---------- [FrameworkBundle] Update console fixtures after #22217 | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes (regression from #22217) | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22217 (comment) | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> cc @fabpot Sorry for the inconvenience :) Commits ------- 6e1cee6 [FrameworkBundle] Update console fixtures after #22217
|
merged, can you please look now at master which is still failing? |
fabpot
added a commit
that referenced
this pull request
Apr 4, 2017
This PR was merged into the 3.3-dev branch. Discussion ---------- [FrameworkBundle] Fix console fixtures | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22278 (comment) | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> cc @nicolas-grekas Commits ------- a7bd944 [FrameworkBundle] Fix console fixtures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @fabpot
Sorry for the inconvenience :)