-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[DI] Fix indexed arguments #22205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DI] Fix indexed arguments #22205
Conversation
To me, |
Oh sorry.. understand the confusion.. this is about plain & simply; Foo:
class: Foo
arguments: { index_0: first, index_1: 2nd, index_2: third } :)) edit: so used to new syntax.. but updated the issue. |
in general; this pass looks very aggressive by default. Shouldnt it only deal with expected about the strategy, named args overwrite indexed ones and we should probably extraxt the resolved index from |
AFAIK, this has never been the case. Ordering based on Currently, this PR and report is bogus, please provide more details if you think otherwise :) |
It's really working in 3.2 :) services:
x:
class: AppBundle\Foo
arguments: { index_0: first, index_1: 2nd, index_2: third }
edit: the order is preserved indeed |
That's why it's documented as a bc break yes, one we chose to do, because such configs are bogus to begin with :) |
See #22185 |
Ok my bad. I just did not expected it (should have) related to |
No pb! A big thank for playing with master and reporting issues, even if this one is not valid :) |
small breakage with 3.2 :)
is now producing