[DI] add ServiceLocatorTagPass::register() to share service locators #22175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4ef4036 to
1ddb17b
Compare
|
👍 |
1ddb17b to
ee17a10
Compare
Taluu
approved these changes
Mar 27, 2017
7144c13 to
31657cc
Compare
ba03a95 to
659df71
Compare
stof
reviewed
Mar 31, 2017
| } | ||
|
|
||
| /** | ||
| * @param Reference[] $refMap |
There was a problem hiding this comment.
the phpdoc does not match the signature (which can confuse some IDEs which will ask consumers to pass the refMap as first argument)
659df71 to
8ff764b
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Apr 3, 2017
…rvice locators (nicolas-grekas) This PR was merged into the 3.3-dev branch. Discussion ---------- [DI] add ServiceLocatorTagPass::register() to share service locators | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Right now, one service locator is created per controller / service subscriber. But since service locators are stateless, this is just wasting resources when several controllers have the exact same set of services managed by their locators (as would be the case when registering the new `AbstractController` as a service subscribers). This PR fixes this issue, and a few related others found along the way. Commits ------- 8ff764b [DI] add ServiceLocatorTagPass::register() to share service locators
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, one service locator is created per controller / service subscriber. But since service locators are stateless, this is just wasting resources when several controllers have the exact same set of services managed by their locators (as would be the case when registering the new
AbstractControlleras a service subscribers).This PR fixes this issue, and a few related others found along the way.