Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Asset] Adding a new version strategy that reads from a manifest JSON file #22046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

[Asset] Adding a new version strategy that reads from a manifest JSON file #22046

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e41cf49
[Asset][FrameworkBundle] Adding a new version strategy that reads fro…
weaverryan Mar 17, 2017
1a3d465
fabbot
weaverryan Mar 17, 2017
6d19549
Removing .json from extension of a file to work around fabbot not lik…
weaverryan Mar 17, 2017
36fa8b3
Fixing a test
weaverryan Mar 17, 2017
0a99143
== => ===
weaverryan Mar 17, 2017
b2c7d32
Another attempt at faking out fabbot. Quick fabbot - look over there!
weaverryan Mar 17, 2017
9ed9c57
Line breaks and not being clever with invalid - just ending with .json
weaverryan Mar 22, 2017
aa32896
Tweaks thanks to Stof!
weaverryan Mar 22, 2017
99251c3
Reworking feature so that json_manifest_path is the config key, and i…
weaverryan Mar 23, 2017
bebf674
Thanks fabbot!
weaverryan Mar 23, 2017
5955f17
Making test compatible with older phpunit versions
weaverryan Mar 23, 2017
14d50e1
Fixing test - the old way is all inside setExpectedException, the new…
weaverryan Mar 23, 2017
ff8869a
Tweaks thanks to fabpot
weaverryan Mar 23, 2017
ada2471
Very minor changes thanks to nicolas-grekas
weaverryan Mar 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tweaks thanks to fabpot
  • Loading branch information
@weaverryan
weaverryan committed Mar 23, 2017
commit ff8869a36f593173c9e8bdfa333f312d3d649530
2 changes: 2 additions & 0 deletions 2 .php_cs.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,7 @@ return PhpCsFixer\Config::create()
->notPath('Symfony/Bundle/FrameworkBundle/Tests/Templating/Helper/Resources/Custom/_name_entry_label.html.php')
// explicit heredoc test
->notPath('Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Resources/views/translation.html.php')
// purposefully invalid JSON
->notPath('Symfony/Component/Asset/Tests/fixtures/manifest-invalid.json')
)
;
2 changes: 1 addition & 1 deletion 2 src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ CHANGELOG
3.3.0
-----

* A new version strategy option called json_manifest_path was added
* Added a new new version strategy option called json_manifest_path
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quotes around "json_manifest_path"?

that allows you to use the JsonManifestVersionStrategy.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backticks here?

* Added support for the `controller.service_arguments` tag, for injecting services into controllers' actions
* Deprecated `cache:clear` with warmup (always call it with `--no-warmup`)
Expand Down
2 changes: 1 addition & 1 deletion 2 src/Symfony/Component/Asset/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ CHANGELOG

3.3.0
-----
* JsonManifestVersionStrategy was added as a way to read final,
* Added JsonManifestVersionStrategy as a way to read final,
versioned paths from a JSON manifest file.

2.7.0
Expand Down
9 changes: 2 additions & 7 deletions 9 src/Symfony/Component/Asset/VersionStrategy/JsonManifestVersionStrategy.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,15 @@
* "css/styles.css": "css/styles.555abc.css"
* }
*
* You could then as for the version of "main.js" or "css/styles.css".
* You could then ask for the version of "main.js" or "css/styles.css".
*/
class JsonManifestVersionStrategy implements VersionStrategyInterface
{
private $manifestPath;

private $manifestData;

/**
* @param string $manifestPath Absolute path to the manifest file.
* @param string $manifestPath Absolute path to the manifest file
*/
public function __construct($manifestPath)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add the phpdoc describing the argument as a string, as we don't have a typehint to tell it

{
Expand All @@ -40,10 +39,6 @@ public function __construct($manifestPath)
* With a manifest, we don't really know or care about what
* the version is. Instead, this returns the path to the
* versioned file.
*
* @param string $path
*
* @return string
*/
public function getVersion($path)
{
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.