Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Deprecate the special SYMFONY__ environment variables #21889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Deprecate the special SYMFONY__ environment variables #21889

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2b8b6c7
Deprecate the special SYMFONY__ environment variables
javiereguiluz Mar 6, 2017
4374128
Deprecated the entire getEnvParameters() method
javiereguiluz Mar 14, 2017
924e18c
Added UPGRADE and CHANGELOG info
javiereguiluz Mar 14, 2017
1c08baa
Minor improvement
javiereguiluz Mar 19, 2017
a1ba61d
Fixed the tested deprecation message
javiereguiluz Mar 20, 2017
247d17e
Don't use deprecated features in tests
javiereguiluz Mar 20, 2017
9e99d7b
Removed unneeded code
javiereguiluz Mar 20, 2017
d9e2375
Define a default value for REDIS_HOST parameter
javiereguiluz Mar 20, 2017
b55f181
Fixed another failing test config
javiereguiluz Mar 21, 2017
3ed6d2f
Unset the env var after the test is finished
javiereguiluz Mar 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added UPGRADE and CHANGELOG info
  • Loading branch information
@javiereguiluz
javiereguiluz committed Mar 19, 2017
commit 924e18c6dba5b785b764cc19684d20a26d7b3c5b
12 changes: 9 additions & 3 deletions 12 UPGRADE-3.3.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ FrameworkBundle
have been deprecated and will be removed in 4.0.

* Extending `ConstraintValidatorFactory` is deprecated and won't be supported in 4.0.

* Class parameters related to routing have been deprecated and will be removed in 4.0.
* router.options.generator_class
* router.options.generator_base_class
Expand All @@ -168,8 +168,8 @@ FrameworkBundle
has been deprecated and will be removed in 4.0. Use the `Symfony\Component\HttpKernel\DependencyInjection\ControllerArgumentValueResolverPass`
class instead.

* The `Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\RoutingResolverPass`
class has been deprecated and will be removed in 4.0. Use the
* The `Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\RoutingResolverPass`
class has been deprecated and will be removed in 4.0. Use the
`Symfony\Component\Routing\DependencyInjection\RoutingResolverPass` class instead.

HttpKernel
Expand All @@ -187,6 +187,12 @@ HttpKernel
which will tell the Kernel to use the response code set on the event's
response object.

* The `getEnvParameters()` method has been deprecated and will be removed in 4.0.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kernel::getEnvParameters()


* The `SYMFONY__` environment variables have been deprecated and they will be
no longer processed automatically by Symfony in 4.0. Use the `%env()%` syntax
to get the value of any environment variable from configuration files instead.

Process
-------

Expand Down
8 changes: 7 additions & 1 deletion 8 UPGRADE-4.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ FrameworkBundle
class instead.

* The `Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\RoutingResolverPass`
class has been removed. Use the
class has been removed. Use the
`Symfony\Component\Routing\DependencyInjection\RoutingResolverPass` class instead.

HttpFoundation
Expand Down Expand Up @@ -321,6 +321,12 @@ HttpKernel
which will tell the Kernel to use the response code set on the event's
response object.

* The `getEnvParameters()` method has been removed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kernel::getEnvParameters()


* The `SYMFONY__` environment variables are no longer processed automatically
by Symfony. Use the `%env()%` syntax to get the value of any environment
variable from configuration files instead.

Ldap
----

Expand Down
2 changes: 2 additions & 0 deletions 2 src/Symfony/Component/HttpKernel/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ CHANGELOG
3.3.0
-----

* Deprecated `getEnvParameters`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kernel::getEnvParameters()

* Deprecated the special `SYMFONY__` environment variables
* added the possibility to change the query string parameter used by `UriSigner`
* deprecated `LazyLoadingFragmentHandler::addRendererService()`
* added `SessionListener`
Expand Down
4 changes: 2 additions & 2 deletions 4 src/Symfony/Component/HttpKernel/Tests/KernelTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,8 +744,8 @@ public function testKernelRootDirNameStartingWithANumber()

/**
* @group legacy
* @expectedDeprecation The Symfony\Component\HttpKernel\Kernel::getEnvParameters() method is deprecated as of 3.3 and will be removed in 4.0. Use the %s syntax to get the value of any environment variable from configuration files instead.
* @expectedDeprecation The support of special environment variables that start with SYMFONY__ (such as "SYMFONY__FOO__BAR") is deprecated as of 3.3 and will be removed in 4.0. Use the %env()% syntax instead to get the value of environment variables in configuration files.
* @expectedDeprecation The Symfony\Component\HttpKernel\Kernel::getEnvParameters() method is deprecated as of 3.3 and will be removed in 4.0. Use the %c syntax to get the value of any environment variable from configuration files instead.
* @expectedDeprecation The support of special environment variables that start with SYMFONY__ (such as "SYMFONY__FOO__BAR") is deprecated as of 3.3 and will be removed in 4.0. Use the %c syntax instead to get the value of environment variables in configuration files.
*/
public function testSymfonyEnvironmentVariables()
{
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.