[HttpFoundation] Fix missing handling of for/host/proto info from "Forwarded" header #21849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40c4d23 to
4c6c13c
Compare
dmaicher
reviewed
Mar 4, 2017
| @@ -1662,7 +1662,7 @@ public function testTrustedProxies() | ||
| // trusted proxy via setTrustedProxies() | ||
| Request::setTrustedProxies(array('3.3.3.3', '2.2.2.2')); | ||
| $this->assertEquals('1.1.1.1', $request->getClientIp()); | ||
| $this->assertEquals('real.example.com', $request->getHost()); | ||
| $this->assertEquals('foo.example.com', $request->getHost()); |
There was a problem hiding this comment.
so technically the behaviour is changed here for handling the X_FORWARDED_HOST header? Does it matter for BC?
There was a problem hiding this comment.
I think nobody reported this bug because nobody is doing double reverse proxies (which is what this needs to be hit). But I doubt this will break, since having a mixed "port from edge" + "host from the second proxy" already makes little sense.
4c6c13c to
04caacb
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Mar 22, 2017
…fo from "Forwarded" header (nicolas-grekas) This PR was merged into the 2.8 branch. Discussion ---------- [HttpFoundation] Fix missing handling of for/host/proto info from "Forwarded" header | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - We're missing handling of for/host/proto info embedded in the `Forwarded` header, as eg in: `Forwarded: for=1.1.1.1:443, host=foo.example.com:1234, proto=https, for=2.2.2.2, host=real.example.com:8080` Commits ------- 04caacb [HttpFoundation] Fix missing handling of for/host/proto info from "Forwarded" header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're missing handling of for/host/proto info embedded in the
Forwardedheader, as eg in:Forwarded: for=1.1.1.1:443, host=foo.example.com:1234, proto=https, for=2.2.2.2, host=real.example.com:8080