-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[FrameworkBundle][PropertyInfo] Move PropertyInfoPass to the PropertyInfo component #21806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
src/Symfony/Component/PropertyInfo/DependencyInjection/CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| CHANGELOG | ||
| ========= | ||
|
|
||
| 3.3.0 | ||
| ----- | ||
|
|
||
| * Added `PropertyInfoPass` |
66 changes: 66 additions & 0 deletions
66
src/Symfony/Component/PropertyInfo/DependencyInjection/PropertyInfoPass.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the Symfony package. | ||
| * | ||
| * (c) Fabien Potencier <fabien@symfony.com> | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace Symfony\Component\PropertyInfo\DependencyInjection; | ||
|
|
||
| use Symfony\Component\DependencyInjection\Argument\IteratorArgument; | ||
| use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface; | ||
| use Symfony\Component\DependencyInjection\Compiler\PriorityTaggedServiceTrait; | ||
| use Symfony\Component\DependencyInjection\ContainerBuilder; | ||
|
|
||
| /** | ||
| * Adds extractors to the property_info service. | ||
| * | ||
| * @author Kévin Dunglas <dunglas@gmail.com> | ||
| */ | ||
| class PropertyInfoPass implements CompilerPassInterface | ||
| { | ||
| use PriorityTaggedServiceTrait; | ||
|
|
||
| private $propertyInfoService; | ||
| private $listExtractorTag; | ||
| private $typeExtractorTag; | ||
| private $descriptionExtractorTag; | ||
| private $accessExtractorTag; | ||
|
|
||
| public function __construct($propertyInfoService = 'property_info', $listExtractorTag = 'property_info.list_extractor', $typeExtractorTag = 'property_info.type_extractor', $descriptionExtractorTag = 'property_info.description_extractor', $accessExtractorTag = 'property_info.access_extractor') | ||
| { | ||
| $this->propertyInfoService = $propertyInfoService; | ||
| $this->listExtractorTag = $listExtractorTag; | ||
| $this->typeExtractorTag = $typeExtractorTag; | ||
| $this->descriptionExtractorTag = $descriptionExtractorTag; | ||
| $this->accessExtractorTag = $accessExtractorTag; | ||
| } | ||
|
|
||
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function process(ContainerBuilder $container) | ||
| { | ||
| if (!$container->hasDefinition($this->propertyInfoService)) { | ||
| return; | ||
| } | ||
|
|
||
| $definition = $container->getDefinition($this->propertyInfoService); | ||
|
|
||
| $listExtractors = $this->findAndSortTaggedServices($this->listExtractorTag, $container); | ||
| $definition->replaceArgument(0, new IteratorArgument($listExtractors)); | ||
|
|
||
| $typeExtractors = $this->findAndSortTaggedServices($this->typeExtractorTag, $container); | ||
| $definition->replaceArgument(1, new IteratorArgument($typeExtractors)); | ||
|
|
||
| $descriptionExtractors = $this->findAndSortTaggedServices($this->descriptionExtractorTag, $container); | ||
| $definition->replaceArgument(2, new IteratorArgument($descriptionExtractors)); | ||
|
|
||
| $accessExtractors = $this->findAndSortTaggedServices($this->accessExtractorTag, $container); | ||
| $definition->replaceArgument(3, new IteratorArgument($accessExtractors)); | ||
| } | ||
| } |
76 changes: 76 additions & 0 deletions
76
src/Symfony/Component/PropertyInfo/Tests/DependencyInjection/PropertyInfoPassTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the Symfony package. | ||
| * | ||
| * (c) Fabien Potencier <fabien@symfony.com> | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace Symfony\Component\PropertyInfo\Tests\DependencyInjection; | ||
|
|
||
| use PHPUnit\Framework\TestCase; | ||
| use Symfony\Component\DependencyInjection\Reference; | ||
| use Symfony\Component\PropertyInfo\DependencyInjection\PropertyInfoPass; | ||
|
|
||
| class PropertyInfoPassTest extends TestCase | ||
| { | ||
| public function testServicesAreOrderedAccordingToPriority() | ||
| { | ||
| $services = array( | ||
| 'n3' => array('tag' => array()), | ||
| 'n1' => array('tag' => array('priority' => 200)), | ||
| 'n2' => array('tag' => array('priority' => 100)), | ||
| ); | ||
|
|
||
| $expected = array( | ||
| new Reference('n1'), | ||
| new Reference('n2'), | ||
| new Reference('n3'), | ||
| ); | ||
|
|
||
| $container = $this->getMockBuilder('Symfony\Component\DependencyInjection\ContainerBuilder')->setMethods(array('findTaggedServiceIds'))->getMock(); | ||
|
|
||
| $container | ||
| ->expects($this->any()) | ||
| ->method('findTaggedServiceIds') | ||
| ->will($this->returnValue($services)); | ||
|
|
||
| $propertyInfoPass = new PropertyInfoPass(); | ||
|
|
||
| $method = new \ReflectionMethod( | ||
| 'Symfony\Component\PropertyInfo\DependencyInjection\PropertyInfoPass', | ||
| 'findAndSortTaggedServices' | ||
| ); | ||
| $method->setAccessible(true); | ||
|
|
||
| $actual = $method->invoke($propertyInfoPass, 'tag', $container); | ||
|
|
||
| $this->assertEquals($expected, $actual); | ||
| } | ||
|
|
||
| public function testReturningEmptyArrayWhenNoService() | ||
| { | ||
| $container = $this->getMockBuilder('Symfony\Component\DependencyInjection\ContainerBuilder')->setMethods(array('findTaggedServiceIds'))->getMock(); | ||
|
|
||
| $container | ||
| ->expects($this->any()) | ||
| ->method('findTaggedServiceIds') | ||
| ->will($this->returnValue(array())) | ||
| ; | ||
|
|
||
| $propertyInfoPass = new PropertyInfoPass(); | ||
|
|
||
| $method = new \ReflectionMethod( | ||
| 'Symfony\Component\PropertyInfo\DependencyInjection\PropertyInfoPass', | ||
| 'findAndSortTaggedServices' | ||
| ); | ||
| $method->setAccessible(true); | ||
|
|
||
| $actual = $method->invoke($propertyInfoPass, 'tag', $container); | ||
|
|
||
| $this->assertEquals(array(), $actual); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this kind of extension point really needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I think, we did it for each other (see #20250 (comment))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not? It allows configuring multiple property info services in an application easily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It adds stuff to maintain and I'm not sure it's really useful, but if you think it is why not.