[DI] Don't try to instantiate reflection class if it doesn't exist #21631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to confirm: the issue seems to come from the |
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Feb 16, 2017
…sn't exist (chalasr) This PR was merged into the 3.3-dev branch. Discussion ---------- [DI] Don't try to instantiate reflection class if it doesn't exist | Q | A | ------------- | --- | Branch? | master | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Introduced in #21419 so master only. It breaks on bundles that ~~do not use the convention for naming their `Configuration`~~ do not have configuration, e.g. SecurityBundle's FirewallEntryPointExtension for which tests are actually broken (see travis). Commits ------- f9b917a [DI] Don't instantiate unexisting reflection class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in #21419 so master only.
It breaks on bundles that
do not use the convention for naming theirdo not have configuration, e.g. SecurityBundle's FirewallEntryPointExtension for which tests are actually broken (see travis).Configuration