Avoid to escape non-ascii characters in argument

If the LC_CTYPE is not set at UTF-8, the escapeshellarg() function will remove every non-ascii characters. As it's usual in europe to have directories with non-ascii chars in their name (ex : ~/Vidéos) the function should throw an exception if we're trying to submit it an argument containing non-ascii param and the LC_CTYPE is not set to use UTF-8
symfony · GuillaumeVerdon · Feb 1, 2017 · Feb 1, 2017 · Feb 1, 2017 · Feb 1, 2017
commit 78620a5968a5f1d073d6df1396d851a30dca9f65
diff --git a/src/Symfony/Component/Process/ProcessUtils.php b/src/Symfony/Component/Process/ProcessUtils.php
@@ -38,6 +38,7 @@ private function __construct()
     */
    public static function escapeArgument($argument)
    {
+
        //Fix for PHP bug #43784 escapeshellarg removes % from given string
        //Fix for PHP bug #49446 escapeshellarg doesn't work on Windows
        //@see https://bugs.php.net/bug.php?id=43784
@@ -70,7 +71,10 @@ public static function escapeArgument($argument)

            return $escapedArgument;
        }
-
+        // Avoid the disapeareance of non-ascii parameters when LC_CTYPE is not set as UTF-8
+        if (preg_match('/[^\x20-\x7f]/', $argument) && strpos("UTF-8", setlocale(LC_CTYPE, "0")) === false) {
+            throw new InvalidArgumentException("argument cannot contains non-ascii characters if the locale LC_CTYPE is not set as UTF-8");
+        }
        return escapeshellarg($argument);
    }