Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[PhpUnitBridge] hide stack trace of expected deprecation failures #21135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2017

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jan 2, 2017

Q A
Branch? 3.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@stof
Copy link
Member

stof commented Jan 2, 2017

this will have an effect only when using simple-phpunit, not when registering the listener explicitly to be used for normal phpunit runs.

couldn't this be handled by the listener constructor instead ?

@xabbuh
Copy link
Member Author

xabbuh commented Jan 2, 2017

For our use cases that will work. But since the blacklist is only evaluated once I wanted to add the listener class as soon as possible. Do you think it's safe to always do that in the listener's constructor?

@stof
Copy link
Member

stof commented Jan 2, 2017

Well, when using the simple-phpunit runner, it would still work (as the constructor is invoked before the line you added).
For usage through the config file, I don't know. It depends when the instantiation takes place. You would need to try it. See Swiftmailer for a project using the bridge through normal PHPUnit usage and registering the listener in the config file for instance.

@nicolas-grekas nicolas-grekas added this to the 3.2 milestone Jan 2, 2017
@xabbuh xabbuh force-pushed the hide-expected-deprecation-stack-trace branch from 9ce8384 to 3777da5 Compare January 2, 2017 17:34
@xabbuh
Copy link
Member Author

xabbuh commented Jan 2, 2017

I can confirm that moving the modification of the blacklist to the listener's constructor still leads to the expected effect.

@nicolas-grekas
Copy link
Member

👍

@fabpot
Copy link
Member

fabpot commented Jan 2, 2017

Thank you @xabbuh.

@fabpot fabpot merged commit 3777da5 into symfony:3.2 Jan 2, 2017
fabpot added a commit that referenced this pull request Jan 2, 2017
…ailures (xabbuh)

This PR was merged into the 3.2 branch.

Discussion
----------

[PhpUnitBridge] hide stack trace of expected deprecation failures

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

3777da5 hide stack trace of expected deprecation failures
@xabbuh xabbuh deleted the hide-expected-deprecation-stack-trace branch January 2, 2017 22:11
@fabpot fabpot mentioned this pull request Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.