[FrameworkBundle] Make TemplateController working without the Templating component #21034
[FrameworkBundle] Make TemplateController working without the Templat…
…ing component
- Loading branch information
commit 89ccbc450ce577a138520f73acfd2e2b6bd4aa23
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the Symfony package. | ||
| * | ||
| * (c) Fabien Potencier <fabien@symfony.com> | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace Symfony\Bundle\FrameworkBundle\Tests\Controller; | ||
|
|
||
| use Symfony\Bundle\FrameworkBundle\Controller\TemplateController; | ||
| use Symfony\Bundle\FrameworkBundle\Tests\TestCase; | ||
| use Symfony\Component\HttpFoundation\Response; | ||
|
|
||
| /** | ||
| * @author Kévin Dunglas <dunglas@gmail.com> | ||
| */ | ||
| class TemplateControllerTest extends TestCase | ||
| { | ||
| public function testTwig() | ||
| { | ||
| $twig = $this->getMockBuilder('\Twig_Environment')->disableOriginalConstructor()->getMock(); | ||
| $twig->expects($this->once())->method('render')->willReturn('bar'); | ||
|
|
||
| $container = $this->getMockBuilder('Symfony\Component\DependencyInjection\ContainerInterface')->getMock(); | ||
| $container->expects($this->at(0))->method('has')->will($this->returnValue(false)); | ||
| $container->expects($this->at(1))->method('has')->will($this->returnValue(true)); | ||
| $container->expects($this->at(2))->method('get')->will($this->returnValue($twig)); | ||
|
|
||
| $controller = new TemplateController(); | ||
| $controller->setContainer($container); | ||
|
|
||
| $this->assertEquals('bar', $controller->templateAction('mytemplate')->getContent()); | ||
| } | ||
|
|
||
| public function testTemplating() | ||
| { | ||
| $templating = $this->getMockBuilder('Symfony\Bundle\FrameworkBundle\Templating\EngineInterface')->getMock(); | ||
| $templating->expects($this->once())->method('renderResponse')->willReturn(new Response('bar')); | ||
|
|
||
| $container = $this->getMockBuilder('Symfony\Component\DependencyInjection\ContainerInterface')->getMock(); | ||
| $container->expects($this->at(0))->method('has')->willReturn(true); | ||
| $container->expects($this->at(1))->method('get')->will($this->returnValue($templating)); | ||
|
|
||
| $controller = new TemplateController(); | ||
| $controller->setContainer($container); | ||
|
|
||
| $this->assertEquals('bar', $controller->templateAction('mytemplate')->getContent()); | ||
| } | ||
|
|
||
| /** | ||
| * @expectedException \LogicException | ||
| * @expectedExceptionMessage You can not use the TemplateController if the Templating Component or the Twig Bundle are not available. | ||
| */ | ||
| public function testNoTwigNorTemplating() | ||
| { | ||
| $container = $this->getMockBuilder('Symfony\Component\DependencyInjection\ContainerInterface')->getMock(); | ||
| $container->expects($this->at(0))->method('has')->willReturn(false); | ||
| $container->expects($this->at(1))->method('has')->willReturn(false); | ||
|
|
||
| $controller = new TemplateController(); | ||
| $controller->setContainer($container); | ||
|
|
||
| $controller->templateAction('mytemplate')->getContent(); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dunglas Are you sure about this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would even remove it as I don't think it helps in any way, does it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing it would indeed be better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in e5ce4c9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was to make fabbot green, I've tried with PHPStorm, both formats enable the autocompletion. Removing it prevent autocompletion by default, but if you have the Symfony plugin then it works.