Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[WebProfilerBundle] Improve AJAX toolbar panel #21007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

[WebProfilerBundle] Improve AJAX toolbar panel #21007

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9bfd54d
[WebProfilerBundle] Fix AJAX toolbar regressions
ro0NL Mar 4, 2017
df7a759
avoid double used class + remove unnecessary class assignments
ro0NL Mar 4, 2017
86ff7a7
use english pluralization
ro0NL Mar 4, 2017
d204c7c
consistent default cell contents
ro0NL Mar 4, 2017
76c18fd
fixed unavailable response regression
ro0NL Mar 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
avoid double used class + remove unnecessary class assignments
  • Loading branch information
@ro0NL
ro0NL committed Mar 4, 2017
commit df7a759ae339673ca105d2c12ef8818cd098991a
2 changes: 1 addition & 1 deletion 2 src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/ajax.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
{% block toolbar %}
{% set icon %}
{{ include('@WebProfiler/Icon/ajax.svg') }}
<span class="sf-toolbar-value sf-toolbar-ajax-requests">0</span>
<span class="sf-toolbar-value sf-toolbar-ajax-request-counter">0</span>
{% endset %}

{% set text %}
Expand Down
3 changes: 1 addition & 2 deletions 3 src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/base_js.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,12 +88,11 @@
var successStreak = 4;
var pendingRequests = 0;
var renderAjaxRequests = function() {
var requestCounter = document.querySelector('.sf-toolbar-ajax-requests');
var requestCounter = document.querySelector('.sf-toolbar-ajax-request-counter');
if (!requestCounter) {
return;
}
requestCounter.textContent = requestStack.length;
requestCounter.className = 'sf-toolbar-ajax-requests sf-toolbar-value';

var infoSpan = document.querySelector(".sf-toolbar-ajax-info");
if (infoSpan) {
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.