Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[HttpFoundation] update changelog #20986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2016
Merged

[HttpFoundation] update changelog #20986

merged 1 commit into from
Dec 19, 2016

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Dec 19, 2016

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #20569
License MIT
Doc PR

@fabpot
Copy link
Member

fabpot commented Dec 19, 2016

Question about those CHANGELOG: are they worth it?

@fabpot
Copy link
Member

fabpot commented Dec 19, 2016

Thank you @xabbuh.

@fabpot fabpot merged commit e91a654 into symfony:master Dec 19, 2016
fabpot added a commit that referenced this pull request Dec 19, 2016
@fabpot
minor #20986 [HttpFoundation] update changelog (xabbuh)
57f8ff2 
This PR was merged into the 3.3-dev branch.

Discussion
----------

[HttpFoundation] update changelog

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #20569
| License       | MIT
| Doc PR        |

Commits
-------

e91a654 [HttpFoundation] update changelog
@lyrixx
Copy link
Member

lyrixx commented Dec 19, 2016 •
edited
Loading

Question about those CHANGELOG: are they worth it?

For what it's worth: I never used them.

@xabbuh xabbuh deleted the pr-20569 branch December 19, 2016 17:23
@xabbuh
Copy link
Member Author

xabbuh commented Dec 19, 2016

Question about those CHANGELOG: are they worth it?

Not sure, but people complained about missing entries in the past. I think we should at least be consistent (either add all new features or completely remove the changelogs).

@juuuuuu
Copy link
Contributor

juuuuuu commented Dec 19, 2016

Question about those CHANGELOG: are they worth it?

Auto-generated CHANGELOG are useless. It's hard to read and to extract useful information from it.

@romainneutron
Copy link
Contributor

@fabpot it would be nice. When I do a composer up and use a new version, I'm usually looking for this CHANGELOG to read BC break, changes and new features.
I agree with @juuuuuu, auto-generated one are useless. However, well documented ones are priceless when upgrading packages regularly

@ro0NL
Copy link
Contributor

ro0NL commented Dec 20, 2016

@xabbuh nice one. Perhaps it's worth clarifying this is about Symfony\Component\HttpFoundation\Cookie.. as we have 2 ;-) (Symfony\Component\BrowserKit\Cookie).

If we add Symfony\Component\BrowserKit\Cookie::fromString we're good as well 👍

@xabbuh
Copy link
Member Author

xabbuh commented Dec 20, 2016

@ro0NL But this is the changelog of the HttpFoundation component. :)

@ro0NL
Copy link
Contributor

ro0NL commented Dec 20, 2016

You're right.. my bad :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
HttpFoundation Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@xabbuh @fabpot @lyrixx @juuuuuu @romainneutron @ro0NL @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.