Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[WebProfiler] added missing event parameter to click handler #20814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[WebProfiler] added missing event parameter to click handler #20814

wants to merge 1 commit into from

Conversation

mktcode
Copy link
Contributor

@mktcode mktcode commented Dec 7, 2016

Q A
Branch? "master"
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT

After updating to symfony 3.2 i realized that the debug toolbar does not get closed any more, throwing an error on javascript console: "event" not defined.
This fixes it.

@mktcode mktcode changed the title added missing event parameter to click handler [WebProfiler] added missing event parameter to click handler Dec 7, 2016
@xabbuh
Copy link
Member

xabbuh commented Dec 7, 2016

Thank for the fix @mktcode. However, this was already fixed by #20717 which gets into master as soon as we merge branches up. So I have to close this PR as a duplicate.

@xabbuh xabbuh closed this Dec 7, 2016
@mktcode mktcode deleted the patch-1 branch December 7, 2016 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.