[VarDumper] Use default color for ellipsed namespaces/paths #20679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I think it makes the class + method more readable ... but I 'd also prefer to not have the ellipsis 😄 |
714c6a7 to
56df574
Compare
|
I tend to agree with @javiereguiluz here. I don't think hidding the namespace is really worth it here |
nicolas-grekas
commented
Nov 29, 2016
| @@ -380,7 +381,7 @@ function isCtrlKey(e) { | ||
| display: inline-block; | ||
| overflow: visible; | ||
| text-overflow: ellipsis; | ||
| width: 5em; | ||
| max-width: 5em; |
There was a problem hiding this comment.
this is a bug fix actually
There was a problem hiding this comment.
shouldn't it go in older branches too ? Or is it only affecting 3.2 ?
There was a problem hiding this comment.
only 3.2, where ellipsis are introduced
56df574 to
ebc23cf
Compare
|
Updated by This will display (simulating namespace that doesn't fit the window width): Or in fullwidth: |
|
👍 |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 29, 2016
…s (nicolas-grekas) This PR was merged into the 3.2 branch. Discussion ---------- [VarDumper] Use default color for ellipsed namespaces/paths | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20669 | License | MIT | Doc PR | - Eases readability by helping the eye to focus more quickly on the class name and less on its namespace. And let' disable ellipses on the profiler panels, fixing #20669 meanwhile.  Commits ------- ebc23cf [VarDumper] Use default color for ellipsed namespaces/paths
Merged
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
…es/paths (nicolas-grekas) This PR was merged into the 3.2 branch. Discussion ---------- [VarDumper] Use default color for ellipsed namespaces/paths | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#20669 | License | MIT | Doc PR | - Eases readability by helping the eye to focus more quickly on the class name and less on its namespace. And let' disable ellipses on the profiler panels, fixing symfony#20669 meanwhile.  Commits ------- ebc23cf [VarDumper] Use default color for ellipsed namespaces/paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eases readability by helping the eye to focus more quickly on the class name and less on its namespace.
And let' disable ellipses on the profiler panels, fixing #20669 meanwhile.