[FrameworkBundle] Don't rely on any parent definition for "cache.annotations" #20601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
commented
Nov 23, 2016
| $container->addCompilerPass(new ValidateWorkflowsPass()); | ||
| $container->addCompilerPass(new CachePoolClearerPass(), PassConfig::TYPE_AFTER_REMOVING); | ||
|
|
||
| if ($container->getParameter('kernel.debug')) { | ||
| $container->addCompilerPass(new AddDebugLogProcessorPass(), PassConfig::TYPE_BEFORE_OPTIMIZATION, -1); | ||
| $container->addCompilerPass(new AddDebugLogProcessorPass(), PassConfig::TYPE_BEFORE_OPTIMIZATION, -32); |
There was a problem hiding this comment.
changing to 32 to leave room for a bit of extensibility
|
ping @stof for validation/approval please |
stof
reviewed
Nov 24, 2016
| $annotationsPool->addArgument(new Reference('monolog.logger.cache')); | ||
| } elseif ($container->has('cache.system')) { | ||
| $systemPool = $container->getDefinition('cache.system'); | ||
| if ($factory === $systemPool->getFactory() && 5 === count($systemArgs = $systemPool->getArguments())) { |
There was a problem hiding this comment.
wouldn't it be more future-proof to use 5 <= ?
9afa586 to
f62b820
Compare
|
Ping @symfony/deciders , we need to make a decision on this one before the end of the week for 3.2 to be ready (3/3). |
|
Last issue on the 3.2 milestone! @stof any comment? |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Nov 26, 2016
…"cache.annotations" (nicolas-grekas) This PR was merged into the 3.2 branch. Discussion ---------- [FrameworkBundle] Don't rely on any parent definition for "cache.annotations" | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Instead of a generic approach that failed in #20537, let's focus on the `cache.annotations` service, which is the one that needs special care because it can be required while the container is being built. See e.g.: - #20234 - http://stackoverflow.com/questions/39625863/vichuploadbundle-inb-symfony-3-cant-load-cache-annotations-service/40626277 - schmittjoh/JMSDiExtraBundle#262 When the service is required at build time, we can't provide it a logger, because no logger service is ready at that time. Still, that doesn't prevent the service from working. The late `CachePoolClearerPass` wires the logger for later instantiations so that `cache.annotations` has a properly configured logger *for the next requests*. Commits ------- f62b820 [FrameworkBundle] Dont rely on any parent definition for "cache.annotations"
Merged
|
@nicolas-grekas So does this mean that whether or not the |
|
cache.annotations will always have a logger, but only after the container is loaded from its dumped version. Which means always if you do offline cache warmup, and not for the very first request otherwise. |
fabpot
added a commit
that referenced
this pull request
Jan 24, 2017
…fore removing passes (nicolas-grekas) This PR was merged into the 3.2 branch. Discussion ---------- [FrameworkBundle] Dont wire "annotations.cached_reader" before removing passes | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21339 | License | MIT | Doc PR | - This PR basically reverts #20601 and wires "annotations.cached_reader" later, so that any compiler passes needing "annotation_reader" at compile time don't get any cache - anyway, it's useless at compile time. Commits ------- e59f0e0 [FrameworkBundle] Dont wire "annotations.cached_reader" before removing passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of a generic approach that failed in #20537, let's focus on the
cache.annotationsservice, which is the one that needs special care because it can be required while the container is being built. See e.g.:When the service is required at build time, we can't provide it a logger, because no logger service is ready at that time. Still, that doesn't prevent the service from working. The late
CachePoolClearerPasswires the logger for later instantiations so thatcache.annotationshas a properly configured logger for the next requests.