[FrameworkBundle] Register the ArrayDenormalizer #20480
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if this should be treated as a bugfix, people could use some specific array denormalizers, adding the generic one could make their application use it instead of their specific denormalizers leading to bugs. |
|
This is very unlikely because:
However the bug is real and annoying. Anytime you try to deserialize a document containing an embedded collection, Symfony fails with a an error hard to understand for newcomers ( |
1a67e2b to
8c5b756
Compare
|
👍 I always registered this one on my own in my applications, but having this done for me in core is much nicer. Status: Reviewed |
|
Thank you @dunglas. |
fabpot
added a commit
that referenced
this pull request
Nov 11, 2016
This PR was squashed before being merged into the 3.1 branch (closes #20480). Discussion ---------- [FrameworkBundle] Register the ArrayDenormalizer | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Registers the `ArrayDenormalizer` class in FrameworkBundle. **Why it's a bug fix?** Because since 3.1, most normalizers are able to deserialize complex types (e.g.: an object embedded in an object). They use the `Class\Name[]` notation to handle collections. However, this only works when the `ArrayDenormalizer` has been registered (it is responsible of handling the `[]` notation). We do it manually in unit tests, but `ArrayDenormalizer` has never been integrated in FrameworkBundle. See the test case for further details. Commits ------- 2eedafc [FrameworkBundle] Register the ArrayDenormalizer
nicolas-grekas
added a commit
that referenced
this pull request
Feb 1, 2017
… case (xabbuh) This PR was merged into the 2.8 branch. Discussion ---------- [FrameworkBundle] add missing functional Serializer test case | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This is needed to make the test introduced in #21370. It basically backports the functional test config as introduced by @dunglas in #20480. Commits ------- 24243ac add missing functional Serializer test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Registers the
ArrayDenormalizerclass in FrameworkBundle.Why it's a bug fix?
Because since 3.1, most normalizers are able to deserialize complex types (e.g.: an object embedded in an object). They use the
Class\Name[]notation to handle collections.However, this only works when the
ArrayDenormalizerhas been registered (it is responsible of handling the[]notation).We do it manually in unit tests, but
ArrayDenormalizerhas never been integrated in FrameworkBundle.See the test case for further details.