Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Routing] Fail properly when a route parameter name cannot be used as a PCRE subpattern name #20474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[Routing] Fail properly when a route parameter name cannot be used as a PCRE subpattern name #20474

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
36b7055
[Routing] Fail properly when a route parameter name cannot be used as…
fancyweb Nov 10, 2016
de9e977
comment fix
fancyweb Nov 10, 2016
ba96e2e
cs fix
fancyweb Nov 10, 2016
55a8ed6
add internal phpdoc tag on the variable maximum length constant
fancyweb Nov 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cs fix
  • Loading branch information
@fancyweb
fancyweb committed Nov 10, 2016
commit ba96e2e35bd8a8c4be869ceb35228ad788a8991c
4 changes: 2 additions & 2 deletions 4 src/Symfony/Component/Routing/RouteCompiler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class RouteCompiler implements RouteCompilerInterface

/**
* The maximum supported length of a PCRE subpattern name
* http://pcre.org/current/doc/html/pcre2pattern.html#SEC16
* http://pcre.org/current/doc/html/pcre2pattern.html#SEC16.
*
* @var int
*/
Expand All @@ -41,7 +41,7 @@ class RouteCompiler implements RouteCompilerInterface
*
* @throws \LogicException If a variable is referenced more than once
* @throws \DomainException If a variable name starts with a digit or if it is too long to be successfully used as
* a PCRE subpattern.
* a PCRE subpattern.
*/
public static function compile(Route $route)
{
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.